8299227: host `exif.org` not found in link in doc comment #74

kumarabhi006 · 2022-12-22T21:32:05Z

Reported broken links are updated accordingly.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8299227: host exif.org not found in link in doc comment

Reviewers

Phil Race (@prrace - Reviewer)
Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/74/head:pull/74
$ git checkout pull/74

Update a local copy of the PR:
$ git checkout pull/74
$ git pull https://git.openjdk.org/jdk20 pull/74/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 74

View PR using the GUI difftool:
$ git pr show -t 74

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/74.diff

bridgekeeper · 2022-12-22T21:32:23Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

kumarabhi006 · 2022-12-22T21:33:38Z

@prrace Updated the broken links for spec version 2.2.

openjdk · 2022-12-22T21:35:41Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-12-22T21:39:20Z

Webrevs

prrace · 2022-12-23T18:30:13Z

src/java.desktop/share/classes/javax/imageio/metadata/doc-files/tiff_metadata.html

@@ -574,7 +574,8 @@ <h3><a id="Compression">Compression</a></h3>
 <th scope="row">9</th>
 <td>Exif JPEG</td>
 <td>Exif-specific JPEG compression (see note following this table)</td>
-<td><a href="http://www.exif.org/Exif2-2.PDF">Exif 2.2 Specification</a>
+<td><a href="https://www.kodak.com/global/plugins/acrobat/en/service/digCam/exifStandard2.pdf">
+    Exif 2.2 Specification</a>


This doesn't seem like a very authorative URL.
It looks quite unstable and could be gone at the whim of whoever maintains that website describing their acrobat plugins ..

I found another link http://web.archive.org/web/20131018091152/http://exif.org/Exif2-2.PDF for spec version 2.2 which is a web archive but the connection is not secure.

Is it ok to have https://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf link and update the Spec version to 2.3 ?

What do you suggest?

I found the webarchive myself yesterday, I did not think it a suitable link for JDK.
Since you haven't found a suitable link for 2.2, I think an update to 2.3 is best mainly because it seems a better place to link to.

Updated to version 2.3.

Can we place that document somewhere(I think that is not easy but still) and provide a link to it?

Did you mean this docment https://www.kodak.com/global/plugins/acrobat/en/service/digCam/exifStandard2.pdf ?

I am not sure if we can do this.

I mean the Exif2-2.PDF from the "web.archive"

I don't have an idea where we can put Exif2-2.PDF and provide a link.
Since we have a suitable link to version 2.3, it's better to point to that link. As mentioned by @prrace also in the comment above.
#74 (comment).

openjdk · 2023-01-05T20:07:22Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299227: host `exif.org` not found in link in doc comment

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

5826a07: 8299693: Change to Xcode12.4+1.1 devkit for building on macOS at Oracle
d49851a: 8299689: Make use of JLine for Console as "opt-in"
1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
284c94e: 8298525: javadoc crashes with "UnsupportedOperationException: Not yet implemented" in SeeTaglet.inherit
9c4ed16: 8299561: VaList.empty() doesn't return a list associated with the global scope
a17f505: 8299476: PPC64 Zero build fails after JDK-8286302
b743519: 8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException: assertTrue: expected true, was false"
8254cbb: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
... and 6 more: https://git.openjdk.org/jdk20/compare/a80c91d0360864e34569b684cf159e2dcdebeaaf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

kumarabhi006 · 2023-01-06T04:47:09Z

/integrate

openjdk · 2023-01-06T04:48:54Z

@kumarabhi006
Your change (at version 414e129) is now ready to be sponsored by a Committer.

TejeshR13 · 2023-01-11T07:40:25Z

/sponsor

openjdk · 2023-01-11T07:42:56Z

Going to push as commit 0abb87a.
Since your change was applied there have been 19 commits pushed to the master branch:

de79162: 8299715: IR test: VectorGatherScatterTest.java fails with SVE randomly
151450e: 8294744: AArch64: applications/kitchensink/Kitchensink.java crashed: assert(oopDesc::is_oop(obj)) failed: not an oop
21d468e: 8299733: AArch64: "unexpected literal addressing mode" assertion failure with -XX:+PrintC1Statistics
5826a07: 8299693: Change to Xcode12.4+1.1 devkit for building on macOS at Oracle
d49851a: 8299689: Make use of JLine for Console as "opt-in"
1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
284c94e: 8298525: javadoc crashes with "UnsupportedOperationException: Not yet implemented" in SeeTaglet.inherit
9c4ed16: 8299561: VaList.empty() doesn't return a list associated with the global scope
... and 9 more: https://git.openjdk.org/jdk20/compare/a80c91d0360864e34569b684cf159e2dcdebeaaf...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-11T07:43:20Z

@TejeshR13 @kumarabhi006 Pushed as commit 0abb87a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Broken links fix

2dfc823

openjdk bot added the rfr Pull request is ready for review label Dec 22, 2022

openjdk bot added the client client-libs-dev@openjdk.org label Dec 22, 2022

Link re-fix

e5e3b92

kumarabhi006 changed the title ~~8299227: host exif.org not found in link in doc comment~~ 8299227: host exif.org not found in link in doc comment Dec 22, 2022

prrace reviewed Dec 23, 2022

View reviewed changes

Links and spec version update

414e129

prrace approved these changes Jan 5, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 6, 2023

mrserb approved these changes Jan 10, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jan 11, 2023

openjdk bot closed this Jan 11, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8299227: host `exif.org` not found in link in doc comment #74

8299227: host `exif.org` not found in link in doc comment #74

kumarabhi006 commented Dec 22, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Dec 22, 2022

kumarabhi006 commented Dec 22, 2022

openjdk bot commented Dec 22, 2022

mlbridge bot commented Dec 22, 2022 •

edited

Loading

prrace Dec 23, 2022

kumarabhi006 Dec 23, 2022

prrace Dec 23, 2022

kumarabhi006 Dec 23, 2022

mrserb Jan 5, 2023

kumarabhi006 Jan 5, 2023

mrserb Jan 6, 2023

kumarabhi006 Jan 6, 2023

openjdk bot commented Jan 5, 2023 •

edited

Loading

kumarabhi006 commented Jan 6, 2023

openjdk bot commented Jan 6, 2023

TejeshR13 commented Jan 11, 2023

openjdk bot commented Jan 11, 2023

openjdk bot commented Jan 11, 2023

8299227: host exif.org not found in link in doc comment #74

8299227: host exif.org not found in link in doc comment #74

Conversation

kumarabhi006 commented Dec 22, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Dec 22, 2022

kumarabhi006 commented Dec 22, 2022

openjdk bot commented Dec 22, 2022

mlbridge bot commented Dec 22, 2022 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Jan 5, 2023 • edited Loading

kumarabhi006 commented Jan 6, 2023

openjdk bot commented Jan 6, 2023

TejeshR13 commented Jan 11, 2023

openjdk bot commented Jan 11, 2023

openjdk bot commented Jan 11, 2023

8299227: host `exif.org` not found in link in doc comment #74

8299227: host `exif.org` not found in link in doc comment #74

kumarabhi006 commented Dec 22, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 22, 2022 •

edited

Loading

openjdk bot commented Jan 5, 2023 •

edited

Loading