8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file#75
8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file#75dcubed-ojdk wants to merge 1 commit intoopenjdk:masterfrom dcubed-ojdk:JDK-8299241
Conversation
…nnecessary core file
|
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
|
@dcubed-ojdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/label add hotspot-runtime |
|
@dcubed-ojdk |
|
@dcubed-ojdk |
|
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@coleenp - Thanks for the review! I'll likely integrate in the AM when I can better |
|
/integrate |
|
Going to push as commit 188911c.
Your commit was automatically rebased without conflicts. |
|
@dcubed-ojdk Pushed as commit 188911c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A trivial fix to keep jdk/jfr/api/consumer/streaming/TestJVMCrash.java from generating
an unnecessary core file.
Ran TestJVMCrash.java on 10 configs in Mach5: linux-aarch64, linux-aarch64-debug,
linux-x64, linux-x64-debug, macosx-aarch64, macosx-aarch64-debug, macosx-x64,
macosx-x64-debug, windows-x64, and windows-x64-debug. All 10 .jtr files reported:
Also ran the open ":jdk_jfr" and closed JFR tests on all 10 platforms. No failures.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/75/head:pull/75$ git checkout pull/75Update a local copy of the PR:
$ git checkout pull/75$ git pull https://git.openjdk.org/jdk20 pull/75/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 75View PR using the GUI difftool:
$ git pr show -t 75Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/75.diff