Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file#75

Closed
dcubed-ojdk wants to merge 1 commit intoopenjdk:masterfrom
dcubed-ojdk:JDK-8299241
Closed

8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file#75
dcubed-ojdk wants to merge 1 commit intoopenjdk:masterfrom
dcubed-ojdk:JDK-8299241

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 22, 2022

A trivial fix to keep jdk/jfr/api/consumer/streaming/TestJVMCrash.java from generating
an unnecessary core file.

Ran TestJVMCrash.java on 10 configs in Mach5: linux-aarch64, linux-aarch64-debug,
linux-x64, linux-x64-debug, macosx-aarch64, macosx-aarch64-debug, macosx-x64,
macosx-x64-debug, windows-x64, and windows-x64-debug. All 10 .jtr files reported:

CreateCoredumpOnCrash turned off, no core file dumped

Also ran the open ":jdk_jfr" and closed JFR tests on all 10 platforms. No failures.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.org/jdk20 pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/75.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@dcubed-ojdk The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Dec 22, 2022
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 22, 2022 23:03
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 22, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good + trivial.

@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 33042a4: 8299237: add ArraysSupport.newLength test to a test group
  • a80c91d: 8299230: Use https: in links
  • 9863f59: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes
  • 5e001d6: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
  • a0a09d5: 8298176: remove OpaqueZeroTripGuardPostLoop once main-loop disappears
  • fef70d7: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus
  • 22007a1: 8298893: Rename option UsePolyIntrinsics to UsePoly1305Intrinsics

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2022
@dcubed-ojdk
Copy link
Member Author

@coleenp - Thanks for the review! I'll likely integrate in the AM when I can better
keep an eye on the CI...

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 23, 2022

Going to push as commit 188911c.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 33042a4: 8299237: add ArraysSupport.newLength test to a test group
  • a80c91d: 8299230: Use https: in links
  • 9863f59: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes
  • 5e001d6: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
  • a0a09d5: 8298176: remove OpaqueZeroTripGuardPostLoop once main-loop disappears
  • fef70d7: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus
  • 22007a1: 8298893: Rename option UsePolyIntrinsics to UsePoly1305Intrinsics

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2022
@openjdk openjdk bot closed this Dec 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2022
@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@dcubed-ojdk Pushed as commit 188911c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8299241 branch December 23, 2022 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hotspot-jfr hotspot-jfr-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants