Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java #81

Closed

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jan 3, 2023

Hi all,

This pull request contains a backport of commit 5b5552ff from the openjdk/jdk repository.

The commit being backported was authored by David Holmes on 2 Jan 2023 and was reviewed by Lance Andersen.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/81/head:pull/81
$ git checkout pull/81

Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.org/jdk20 pull/81/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 81

View PR using the GUI difftool:
$ git pr show -t 81

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/81.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2023

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5b5552ff2a5fccaa9a34886d9df4c0075fc8f5e8 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 031829d: 8298324: Unable to run shell test with make

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dholmes-ora
Copy link
Member Author

/label add core-libs

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@dholmes-ora
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

Going to push as commit 8254cbb.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 031829d: 8298324: Unable to run shell test with make

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2023
@openjdk openjdk bot closed this Jan 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@dholmes-ora Pushed as commit 8254cbb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jan 3, 2023

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
1 participant