8299689: Make use of JLine for Console as "opt-in"

[naotoj]

Due to the fact that JLine spawns native processes to obtain terminal information on macOS/Linux, we decided to disable the JLine by default for performance degradation reasons. It is still possible to enable it by specifying it on the command line with jdk.console system property (not a public one though). Once we have a solution to avoid spawning processes, JLine may be back for use in the future.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8299689: Make use of JLine for Console as "opt-in"
• JDK-8299690: Make use of JLine for Console as "opt-in" (CSR)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer) ⚠️ Review applies to b15a8bda
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/88/head:pull/88
$ git checkout pull/88

Update a local copy of the PR:
$ git checkout pull/88
$ git pull https://git.openjdk.org/jdk20 pull/88/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 88

View PR using the GUI difftool:
$ git pr show -t 88

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/88.diff

[bridgekeeper]

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@naotoj The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9a948725)
• 00: Full (b15a8bda)

[AlanBateman]

The overall change looks fine but I think for the next edit that we should move most of this comment to Console as it's Console that selects the behavior and that skips errors. Also once the SM execution mode goes away then we can re-visit that behavior.

[naotoj]

Makes sense. The comment has been moved to Console.

[jaikiran]

Hello Naoto, this looks fine to me. The RedirectTest.java will need an update on the copyright year.

[openjdk]

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299689: Make use of JLine for Console as "opt-in"

Reviewed-by: jpai, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
• 5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
• 136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
• 284c94e: 8298525: javadoc crashes with "UnsupportedOperationException: Not yet implemented" in SeeTaglet.inherit
• 9c4ed16: 8299561: VaList.empty() doesn't return a list associated with the global scope

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[naotoj]

/integrate

[openjdk]

Going to push as commit d49851a.
Since your change was applied there have been 5 commits pushed to the master branch:

• 1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
• 5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
• 136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
• 284c94e: 8298525: javadoc crashes with "UnsupportedOperationException: Not yet implemented" in SeeTaglet.inherit
• 9c4ed16: 8299561: VaList.empty() doesn't return a list associated with the global scope

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj Pushed as commit d49851a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.