-
Notifications
You must be signed in to change notification settings - Fork 61
8299090: Specify coordinate order for additional CaptureCallState parameters on class as well #95
Conversation
👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into |
@JornVernee The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the reviews, could you review the CSR as well? |
@JornVernee This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 3918f9f.
Your commit was automatically rebased without conflicts. |
@JornVernee Pushed as commit 3918f9f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A small doc clarification that also specifies where the additional MemorySegment parameter of a downcall method handle linked with the captureCallState option appears in the parameter list, on the CaptureCallState class.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/95/head:pull/95
$ git checkout pull/95
Update a local copy of the PR:
$ git checkout pull/95
$ git pull https://git.openjdk.org/jdk20 pull/95/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 95
View PR using the GUI difftool:
$ git pr show -t 95
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/95.diff