-
Notifications
You must be signed in to change notification settings - Fork 61
8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR #96
8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR #96
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@RealCLanger The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for confirming, @naotoj /integrate |
Going to push as commit 752a370.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 752a370. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8299439, commit 3b374c01 from the openjdk/jdk repository.
The commit being backported was authored by Justin Lu on 4 Jan 2023 and was reviewed by Naoto Sato, Lance Andersen and Jaikiran Pai.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/96/head:pull/96
$ git checkout pull/96
Update a local copy of the PR:
$ git checkout pull/96
$ git pull https://git.openjdk.org/jdk20 pull/96/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 96
View PR using the GUI difftool:
$ git pr show -t 96
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/96.diff