Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.
/ jdk20 Public archive

8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR #96

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jan 11, 2023

Hi all,

This pull request contains a backport of JDK-8299439, commit 3b374c01 from the openjdk/jdk repository.

The commit being backported was authored by Justin Lu on 4 Jan 2023 and was reviewed by Naoto Sato, Lance Andersen and Jaikiran Pai.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/96/head:pull/96
$ git checkout pull/96

Update a local copy of the PR:
$ git checkout pull/96
$ git pull https://git.openjdk.org/jdk20 pull/96/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 96

View PR using the GUI difftool:
$ git pr show -t 96

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/96.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3b374c0153950ab193f3a188b57d3404b4ce2fe2 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 945ef07: 8299862: OfAddress setter should disallow heap segments
  • 636976a: 8299849: Revert JDK-8294461: wrong effectively final determination by javac
  • 0abb87a: 8299227: host exif.org not found in link in doc comment
  • de79162: 8299715: IR test: VectorGatherScatterTest.java fails with SVE randomly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@RealCLanger The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2023

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@RealCLanger
Copy link
Contributor Author

Thanks for confirming, @naotoj

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

Going to push as commit 752a370.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 3918f9f: 8299090: Specify coordinate order for additional CaptureCallState parameters on class as well
  • 945ef07: 8299862: OfAddress setter should disallow heap segments
  • 636976a: 8299849: Revert JDK-8294461: wrong effectively final determination by javac
  • 0abb87a: 8299227: host exif.org not found in link in doc comment
  • de79162: 8299715: IR test: VectorGatherScatterTest.java fails with SVE randomly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2023
@openjdk openjdk bot closed this Jan 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@RealCLanger Pushed as commit 752a370.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants