Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8278965: crash in SymbolTable::do_lookup #11

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Mar 2, 2023

Other than a minor conflict in systemDictionary.cpp, the backport is the same as the original fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/jdk20u pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/11.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2023

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 582b943439488a0f43482b67c0bc0d4975bf4023 8278965: crash in SymbolTable::do_lookup Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 2, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 2, 2023

Webrevs

Copy link

@fparain fparain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@calvinccheung
Copy link
Member Author

Thanks @fparain for the review.

/clean

@openjdk openjdk bot added the clean label Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@calvinccheung This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278965: crash in SymbolTable::do_lookup

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 2, 2023
@calvinccheung
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

Going to push as commit f33f25f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 2, 2023
@openjdk openjdk bot closed this Mar 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@calvinccheung Pushed as commit f33f25f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8278965-crash-SymbolTable-do_lookup branch March 2, 2023 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants