Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8299194: CustomTzIDCheckDST.java may fail at future date #3

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented Feb 1, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299194: CustomTzIDCheckDST.java may fail at future date

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/jdk20u pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/3.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2023

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5e2de89628aaf6acb8e458fb417426ca5e477bea 8299194: CustomTzIDCheckDST.java may fail at future date Feb 1, 2023
@openjdk
Copy link

openjdk bot commented Feb 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 1, 2023

@takiguc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299194: CustomTzIDCheckDST.java may fail at future date

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2023

Webrevs

@takiguc
Copy link
Author

takiguc commented Feb 4, 2023

jdk20u-fix-yes is verified

/integrate

@openjdk
Copy link

openjdk bot commented Feb 4, 2023

Going to push as commit d431a7c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 4, 2023
@openjdk openjdk bot closed this Feb 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 4, 2023
@openjdk
Copy link

openjdk bot commented Feb 4, 2023

@takiguc Pushed as commit d431a7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant