Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument #32

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Mar 29, 2023

Backport of JDK-8300079. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/32/head:pull/32
$ git checkout pull/32

Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.org/jdk20u.git pull/32/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32

View PR using the GUI difftool:
$ git pr show -t 32

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/32.diff

Webrev

Link to Webrev Comment

…t NULL src argument

Reviewed-by: roland, chagedorn, kvn
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2023

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 45e4e00981ef8b4bf143afce0889698319273c1d 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument Mar 29, 2023
@openjdk
Copy link

openjdk bot commented Mar 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2023

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

Going to push as commit aae19b3.
Since your change was applied there have been 9 commits pushed to the master branch:

  • ac96054: 8302595: use-after-free related to GraphKit::clone_map
  • fcd422d: 8302594: use-after-free in Node::destruct
  • aa6d177: 8297730: C2: Arraycopy intrinsic throws incorrect exception
  • bae3733: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline
  • c0a87a2: 8300823: UB: Compile::_phase_optimize_finished is initialized too late
  • b4429d0: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
  • 572b05a: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE
  • 760ff6e: 8299179: ArrayFill with store on backedge needs to reduce length by 1
  • 71deb0b: 8304871: Use default visibility for static library builds

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2023
@openjdk openjdk bot closed this Apr 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@TobiHartmann Pushed as commit aae19b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant