8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted

[TobiHartmann]

Backport of JDK-8299570. Applies cleanly. Approval is pending.

Thanks,
Tobias

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/44/head:pull/44
$ git checkout pull/44

Update a local copy of the PR:
$ git checkout pull/44
$ git pull https://git.openjdk.org/jdk20u.git pull/44/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 44

View PR using the GUI difftool:
$ git pr show -t 44

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/44.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (11e93e20)

[chhagedorn]

Looks good!

[TobiHartmann]

Thanks, Christian!

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• db88ed0: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
• 17dfaaf: 8300590: [JVMCI] BytecodeFrame.equals is broken
• cbc2f89: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
• 0343ba4: 8299959: C2: CmpU::Value must filter overflow computation against local sub computation
• aae19b3: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
• ac96054: 8302595: use-after-free related to GraphKit::clone_map
• fcd422d: 8302594: use-after-free in Node::destruct
• aa6d177: 8297730: C2: Arraycopy intrinsic throws incorrect exception
• bae3733: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline
• c0a87a2: 8300823: UB: Compile::_phase_optimize_finished is initialized too late
• ... and 4 more: https://git.openjdk.org/jdk20u/compare/0d71795814ed255c4a6e2b51cee01a264a407ad6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit a43d750.
Since your change was applied there have been 18 commits pushed to the master branch:

• 7680690: 8303508: Vector.lane() gets wrong value on x86
• 15bae6f: 8304683: Memory leak in WB_IsMethodCompatible
• 9c6b17d: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
• c23e1cc: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
• db88ed0: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
• 17dfaaf: 8300590: [JVMCI] BytecodeFrame.equals is broken
• cbc2f89: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
• 0343ba4: 8299959: C2: CmpU::Value must filter overflow computation against local sub computation
• aae19b3: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
• ac96054: 8302595: use-after-free related to GraphKit::clone_map
• ... and 8 more: https://git.openjdk.org/jdk20u/compare/0d71795814ed255c4a6e2b51cee01a264a407ad6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit a43d750.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.