Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8298887: On the latest macOS+XCode the Robot API may report wrong colors #47

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Apr 4, 2023

Hi all,
This pull request contains a backport of commit 50120396 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 22 Dec 2022 and was reviewed by Alexander Zvegintsev.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298887: On the latest macOS+XCode the Robot API may report wrong colors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.org/jdk20u.git pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/47.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 50120396b6cca1219fb5dd42a11e4b29b79bd3bd 8298887: On the latest macOS+XCode the Robot API may report wrong colors Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review April 5, 2023 07:01
@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298887: On the latest macOS+XCode the Robot API may report wrong colors

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 2556e13: 8201516: DebugNonSafepoints generates incorrect information
  • a32006a: 8303564: C2: "Bad graph detected in build_loop_late" after a CMove is wrongly split thru phi
  • 322bce7: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
  • a43d750: 8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted
  • 7680690: 8303508: Vector.lane() gets wrong value on x86
  • 15bae6f: 8304683: Memory leak in WB_IsMethodCompatible
  • 9c6b17d: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
  • c23e1cc: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • db88ed0: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
  • 17dfaaf: 8300590: [JVMCI] BytecodeFrame.equals is broken
  • ... and 12 more: https://git.openjdk.org/jdk20u/compare/0d71795814ed255c4a6e2b51cee01a264a407ad6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Apr 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2023

Going to push as commit 3f8adc4.
Since your change was applied there have been 52 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2023
@openjdk openjdk bot closed this Apr 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@mrserb Pushed as commit 3f8adc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant