Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

JDK-8297587: Upgrade JLine to 3.22.0 #56

Closed
wants to merge 2 commits into from

Conversation

prkoppul
Copy link

@prkoppul prkoppul commented Apr 20, 2023

Clean backport


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8297587: Upgrade JLine to 3.22.0 ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.
  • JDK-8304498: JShell does not switch to raw mode when there is no /bin/test ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/56/head:pull/56
$ git checkout pull/56

Update a local copy of the PR:
$ git checkout pull/56
$ git pull https://git.openjdk.org/jdk20u.git pull/56/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 56

View PR using the GUI difftool:
$ git pr show -t 56

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/56.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2023

👋 Welcome back pkoppula! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@prkoppul
Copy link
Author

/issue JDK-8304498

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 20, 2023
@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@prkoppul
Adding additional issue to issue list: 8304498: JShell does not switch to raw mode when there is no /bin/test.

@prkoppul
Copy link
Author

Reviewers: @coffeys

@mlbridge
Copy link

mlbridge bot commented Apr 20, 2023

Webrevs

Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this given that these are clean ports. Don't forget to obtain OpenJDK approval before integration.

@openjdk
Copy link

openjdk bot commented Apr 20, 2023

@prkoppul This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297587: Upgrade JLine to 3.22.0
8304498: JShell does not switch to raw mode when there is no /bin/test

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2023
@prkoppul
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 24, 2023
@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@prkoppul
Your change (at version 505ea6c) is now ready to be sponsored by a Committer.

@robm-openjdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

Going to push as commit 6db9050.
Since your change was applied there have been 24 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2023
@openjdk openjdk bot closed this Apr 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 24, 2023
@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@robm-openjdk @prkoppul Pushed as commit 6db9050.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
3 participants