Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8289735: UTIL_LOOKUP_PROGS fails on pathes with space #63

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 25, 2023

I had to resolve configure.ac


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/63/head:pull/63
$ git checkout pull/63

Update a local copy of the PR:
$ git checkout pull/63
$ git pull https://git.openjdk.org/jdk20u.git pull/63/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 63

View PR using the GUI difftool:
$ git pr show -t 63

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/63.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bad6aa68e4d491e819ab22e91dd5d65bb094120e 8289735: UTIL_LOOKUP_PROGS fails on pathes with space Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289735: UTIL_LOOKUP_PROGS fails on pathes with space
8306976: UTIL_REQUIRE_SPECIAL warning on grep

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

Adding follow up JDK-8306976 inline.

/issue add 8306976

@openjdk openjdk bot removed clean ready Pull request is ready to be integrated labels Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@RealCLanger
Adding additional issue to issue list: 8306976: UTIL_REQUIRE_SPECIAL warning on grep.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 27, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2023

Going to push as commit 9ae9af9.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 12d24f2: 8306825: Monitor deflation might be accidentally disabled by zero intervals
  • 931f350: 8304295: harfbuzz build fails with GCC 7 after JDK-8301998
  • 3607285: 8304760: Add 2 Microsoft TLS roots
  • 39ebb01: 8305975: Add TWCA Global Root CA
  • 2109cd2: 8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable
  • 5d2c255: 8305994: Guarantee eventual async monitor deflation
  • 82bafc6: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
  • 7880add: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 2654070: 8306734: Shenandoah: Missing barriers on deoptimization path
  • 63da061: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed
  • ... and 2 more: https://git.openjdk.org/jdk20u/compare/c0604cb04ef6729b4ec1e17cfdcd28e8f8507c7e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2023
@openjdk openjdk bot closed this May 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

@RealCLanger Pushed as commit 9ae9af9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-bad6aa68 branch May 4, 2023 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants