Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8304295: harfbuzz build fails with GCC 7 after JDK-8301998 #68

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Apr 27, 2023

Hi all,
This pull request contains a backport of commit 34e66ce1 from the openjdk/jdk repository.
The commit being backported was authored by Joshua Cao on 1 Apr 2023 and was reviewed by Aleksey Shipilev, Erik Joelsson, Sergey Bylokhov and Julian Waters.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304295: harfbuzz build fails with GCC 7 after JDK-8301998

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/68/head:pull/68
$ git checkout pull/68

Update a local copy of the PR:
$ git checkout pull/68
$ git pull https://git.openjdk.org/jdk20u.git pull/68/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 68

View PR using the GUI difftool:
$ git pr show -t 68

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/68.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 34e66ce1ef2decc81557a362d6242313e98417fa 8304295: harfbuzz build fails with GCC 7 after JDK-8301998 Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review April 27, 2023 17:03
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304295: harfbuzz build fails with GCC 7 after JDK-8301998

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented May 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 3, 2023

Going to push as commit 931f350.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 3607285: 8304760: Add 2 Microsoft TLS roots
  • 39ebb01: 8305975: Add TWCA Global Root CA
  • 2109cd2: 8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable
  • 5d2c255: 8305994: Guarantee eventual async monitor deflation
  • 82bafc6: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
  • 7880add: 8306883: Thread stacksize is reported with wrong units in os::create_thread logging
  • 2654070: 8306734: Shenandoah: Missing barriers on deoptimization path
  • 63da061: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed
  • 5122def: 8305403: Shenandoah evacuation workers may deadlock
  • 481a9c1: 8305352: updateIconImages may lead to deadlock after JDK-8276849

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 3, 2023
@openjdk openjdk bot closed this May 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 3, 2023
@openjdk
Copy link

openjdk bot commented May 3, 2023

@mrserb Pushed as commit 931f350.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant