-
Notifications
You must be signed in to change notification settings - Fork 43
8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable #70
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8306774-gadt-test-improv
git fetch https://git.openjdk.org/jdk20u.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
…774-gadt-test-improv
Push approval is here, integrating 2/3. /integrate |
Going to push as commit 2109cd2. |
Backport the test reliability fix. The backport was not clean, because there was a conflict in
ProblemList
that took the test away from it. I saw no point in backporting the unclean addition to the problem-list, so this PR just omits any changes to a problemlist.Additional testing:
runtime/Monitor
tier1 tier2 tier3
(together with 8306825: Monitor deflation might be accidentally disabled by zero intervals #71)tier1 tier2 tier3
(together with 8306825: Monitor deflation might be accidentally disabled by zero intervals #71)Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/70/head:pull/70
$ git checkout pull/70
Update a local copy of the PR:
$ git checkout pull/70
$ git pull https://git.openjdk.org/jdk20u.git pull/70/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 70
View PR using the GUI difftool:
$ git pr show -t 70
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/70.diff
Webrev
Link to Webrev Comment