Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk20u Public archive

8307134: Add GTS root CAs #73

Closed
wants to merge 0 commits into from
Closed

Conversation

jianglizhou
Copy link
Contributor

@jianglizhou jianglizhou commented May 4, 2023

Backport to JDK 20u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/73/head:pull/73
$ git checkout pull/73

Update a local copy of the PR:
$ git checkout pull/73
$ git pull https://git.openjdk.org/jdk20u.git pull/73/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 73

View PR using the GUI difftool:
$ git pr show -t 73

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/73.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2023

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03030d47ebee5c20919fe0162ec86d3d400cd955 8307134: Add GTS root CAs May 4, 2023
@openjdk
Copy link

openjdk bot commented May 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 4, 2023

@jianglizhou This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307134: Add GTS root CAs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 4, 2023

⚠️ @jianglizhou a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 9ae9af98fac38d48965fbed8b4cbf58b71fbb26f
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2023
@mlbridge
Copy link

mlbridge bot commented May 4, 2023

Webrevs

@jianglizhou
Copy link
Contributor Author

The Ready Label in this PR says the "Pull request is ready to be integrated". @seanjmullan and @rhalade Could you please review this backport PR if review is needed, or confirm the PR can be integrated directly? Thanks.

@rhalade
Copy link
Member

rhalade commented May 5, 2023

Since this is a clean backport, you can integrate after receiving approval from OpenJDK with label "jdk20u-fix-yes" added to main bug.

@jianglizhou
Copy link
Contributor Author

Since this is a clean backport, you can integrate after receiving approval from OpenJDK with label "jdk20u-fix-yes" added to main bug.

Thanks for clarifying.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants