Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8311689: Wrong visible amount in Adjustable of ScrollPane #111

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Jul 11, 2023

This is a clean backport of JDK-8311689 which is a regression from JDK-8297923.


This pull request contains a backport of commit b3f34039 from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 11 Jul 2023 and was reviewed by Phil Race, Harshitha Onkar and Sergey Bylokhov.

@prrace @honkar-jdk @mrserb


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311689: Wrong visible amount in Adjustable of ScrollPane (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/111/head:pull/111
$ git checkout pull/111

Update a local copy of the PR:
$ git checkout pull/111
$ git pull https://git.openjdk.org/jdk21.git pull/111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 111

View PR using the GUI difftool:
$ git pr show -t 111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/111.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b3f34039fedd3c49404783ec880e1885dceb296b 8311689: Wrong visible amount in Adjustable of ScrollPane Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311689: Wrong visible amount in Adjustable of ScrollPane

Reviewed-by: honkar, azvegint, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 11, 2023
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2023

Going to push as commit 480dc22.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2023
@openjdk openjdk bot closed this Jul 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@aivanov-jdk Pushed as commit 480dc22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants