Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8308694: Clarify reversed() default methods' implementation requirements #115

Conversation

stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Jul 12, 2023

Hi all,

This pull request contains a backport of commit f82c8184 from the openjdk/jdk repository.

The commit being backported was authored by Stuart Marks on 12 Jul 2023 and was reviewed by Roger Riggs.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8311845 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8308694: Clarify reversed() default methods' implementation requirements (Bug - P3)
  • JDK-8311845: Clarify reversed() default methods' implementation requirements (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/115/head:pull/115
$ git checkout pull/115

Update a local copy of the PR:
$ git checkout pull/115
$ git pull https://git.openjdk.org/jdk21.git pull/115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 115

View PR using the GUI difftool:
$ git pr show -t 115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/115.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2023

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f82c8184b26142da4018ae096cfa39d87a4c6540 8308694: Clarify reversed() default methods' implementation requirements Jul 12, 2023
@openjdk
Copy link

openjdk bot commented Jul 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 12, 2023
@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308694: Clarify reversed() default methods' implementation requirements

Reviewed-by: naoto, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 82c8b28: 8156889: ListKeychainStore.sh fails in some virtualized environments

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 12, 2023
Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stuart-marks
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2023

Going to push as commit f6ad56b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 82c8b28: 8156889: ListKeychainStore.sh fails in some virtualized environments

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2023
@openjdk openjdk bot closed this Jul 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2023
@openjdk
Copy link

openjdk bot commented Jul 12, 2023

@stuart-marks Pushed as commit f6ad56b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants