8309862: Unsafe list operations in JfrStringPool

[mgronlun]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309862: Unsafe list operations in JfrStringPool (Bug - P2)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/jdk21.git pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/12.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mgronlun]

/integrate

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@mgronlun This pull request has not yet been marked as ready for integration.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mgronlun]

/integrate

[openjdk]

@mgronlun This pull request has not yet been marked as ready for integration.

[mlbridge]

Webrevs

• 00: Full (2986c9ab)

[kevinrushforth]

@mgronlun This needs a Reviewer to approve.

[mgronlun]

@mgronlun This needs a Reviewer to approve.

I thought a clean backport did not need a review. As described in https://wiki.openjdk.org/display/SKARA/Backports

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309862: Unsafe list operations in JfrStringPool

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

I thought a clean backport did not need a review. As described in https://wiki.openjdk.org/display/SKARA/Backports

That's true for backports to update releases. Backports to JDK feature release stabilization repos require review. See:

https://mail.openjdk.org/pipermail/jdk-dev/2023-April/007612.html

We should update the Wiki to reflect this.

[mgronlun]

/integrate

[openjdk]

Going to push as commit ea4ab65.

[openjdk]

@mgronlun Pushed as commit ea4ab65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mgronlun]

I thought a clean backport did not need a review. As described in https://wiki.openjdk.org/display/SKARA/Backports

That's true for backports to update releases. Backports to JDK feature release stabilization repos require review. See:

https://mail.openjdk.org/pipermail/jdk-dev/2023-April/007612.html

We should update the Wiki to reflect this.

I see it was detailed in the Q and A. Thanks Kevin.