Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8311867: StructuredTaskScope.shutdown does not interrupt newly started threads #123

Closed

Conversation

AlanBateman
Copy link

@AlanBateman AlanBateman commented Jul 13, 2023

Clean backport of https://git.openjdk.org/jdk/pull/14833


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311867: StructuredTaskScope.shutdown does not interrupt newly started threads (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/123/head:pull/123
$ git checkout pull/123

Update a local copy of the PR:
$ git checkout pull/123
$ git pull https://git.openjdk.org/jdk21.git pull/123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 123

View PR using the GUI difftool:
$ git pr show -t 123

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/123.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 92a04e201e68aa4d682053cef4b36180ec5620f5 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 13, 2023
@AlanBateman AlanBateman marked this pull request as ready for review July 13, 2023 18:01
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2023

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 bug fix, approved for backport.

@openjdk
Copy link

openjdk bot commented Jul 14, 2023

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311867: StructuredTaskScope.shutdown does not interrupt newly started threads

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • d370b96: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality
  • b4f19f5: 8306785: fix deficient spliterators for Sequenced Collections
  • 65ed787: 8294401: Update jfr man page to include recently added features

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2023
@AlanBateman
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 14, 2023

Going to push as commit 281aee9.
Since your change was applied there have been 3 commits pushed to the master branch:

  • d370b96: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality
  • b4f19f5: 8306785: fix deficient spliterators for Sequenced Collections
  • 65ed787: 8294401: Update jfr man page to include recently added features

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2023
@openjdk openjdk bot closed this Jul 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2023
@openjdk
Copy link

openjdk bot commented Jul 14, 2023

@AlanBateman Pushed as commit 281aee9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants