-
Notifications
You must be signed in to change notification settings - Fork 66
6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality #125
Conversation
…nctionality Reviewed-by: naoto
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 117 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d370b96.
Your commit was automatically rebased without conflicts. |
@justin-curtis-lu Pushed as commit d370b96. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which backports openjdk/jdk@6cb9ec3
Thank you
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/125/head:pull/125
$ git checkout pull/125
Update a local copy of the PR:
$ git checkout pull/125
$ git pull https://git.openjdk.org/jdk21.git pull/125/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 125
View PR using the GUI difftool:
$ git pr show -t 125
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/125.diff
Webrev
Link to Webrev Comment