Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality #125

Closed

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jul 13, 2023

Please review this PR which backports openjdk/jdk@6cb9ec3

Thank you


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8311106 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality (Bug - P4)
  • JDK-8311106: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/125/head:pull/125
$ git checkout pull/125

Update a local copy of the PR:
$ git checkout pull/125
$ git pull https://git.openjdk.org/jdk21.git pull/125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 125

View PR using the GUI difftool:
$ git pr show -t 125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/125.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jul 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

Reviewed-by: naoto, lancea, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

  • b4f19f5: 8306785: fix deficient spliterators for Sequenced Collections
  • 65ed787: 8294401: Update jfr man page to include recently added features
  • 2475bba: 8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration
  • 99d87e9: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
  • d174dde: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf
  • f792475: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
  • 5f1d762: 8310656: RISC-V: __builtin___clear_cache can fail silently.
  • f6ad56b: 8308694: Clarify reversed() default methods' implementation requirements
  • 82c8b28: 8156889: ListKeychainStore.sh fails in some virtualized environments
  • 72cf3c9: 8295894: Remove SECOM certificate that is expiring in September 2023
  • ... and 107 more: https://git.openjdk.org/jdk21/compare/bb377b26730f3d9da7c76e0d171517e811cef3ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

Going to push as commit d370b96.
Since your change was applied there have been 117 commits pushed to the master branch:

  • b4f19f5: 8306785: fix deficient spliterators for Sequenced Collections
  • 65ed787: 8294401: Update jfr man page to include recently added features
  • 2475bba: 8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration
  • 99d87e9: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
  • d174dde: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf
  • f792475: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
  • 5f1d762: 8310656: RISC-V: __builtin___clear_cache can fail silently.
  • f6ad56b: 8308694: Clarify reversed() default methods' implementation requirements
  • 82c8b28: 8156889: ListKeychainStore.sh fails in some virtualized environments
  • 72cf3c9: 8295894: Remove SECOM certificate that is expiring in September 2023
  • ... and 107 more: https://git.openjdk.org/jdk21/compare/bb377b26730f3d9da7c76e0d171517e811cef3ce...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 13, 2023
@openjdk openjdk bot closed this Jul 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@justin-curtis-lu Pushed as commit d370b96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
4 participants