Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8311038: Incorrect exhaustivity computation #127

Closed

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jul 14, 2023

Hi all,

This pull request contains a backport of commit bbb7ce51 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 14 Jul 2023 and was reviewed by Vicente Romero.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311038: Incorrect exhaustivity computation (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/127/head:pull/127
$ git checkout pull/127

Update a local copy of the PR:
$ git checkout pull/127
$ git pull https://git.openjdk.org/jdk21.git pull/127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 127

View PR using the GUI difftool:
$ git pr show -t 127

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/127.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2023

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bbb7ce5137cd3e8365552b42610e19b7ebe43ba1 8311038: Incorrect exhaustivity computation Jul 14, 2023
@openjdk
Copy link

openjdk bot commented Jul 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 14, 2023
@openjdk
Copy link

openjdk bot commented Jul 14, 2023

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jul 14, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2023

Webrevs

Copy link

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311038: Incorrect exhaustivity computation

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • b380d1b: 8307526: [JFR] Better handling of tampered JFR repository
  • b6827ff: 8311825: Duplicate qualified enum constants not detected
  • a08c6b9: 8312093: Incorrect javadoc comment text
  • 4fcb0b2: 8312098: Update man page for javadoc
  • 49479db: 8311647: Memory leak in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
  • c199b8c: 8303134: JFR: Missing stack trace during chunk rotation stress
  • fd949c7: 8244289: fatal error: Possible safepoint reached by thread that does not allow it

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2023
@lahodaj
Copy link
Contributor Author

lahodaj commented Jul 18, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 18, 2023

Going to push as commit 7a5d6f9.
Since your change was applied there have been 8 commits pushed to the master branch:

  • b8eddab: 8310814: Clarify the targetName parameter of Lookup::findClass
  • b380d1b: 8307526: [JFR] Better handling of tampered JFR repository
  • b6827ff: 8311825: Duplicate qualified enum constants not detected
  • a08c6b9: 8312093: Incorrect javadoc comment text
  • 4fcb0b2: 8312098: Update man page for javadoc
  • 49479db: 8311647: Memory leak in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ttyname_1r
  • c199b8c: 8303134: JFR: Missing stack trace during chunk rotation stress
  • fd949c7: 8244289: fatal error: Possible safepoint reached by thread that does not allow it

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 18, 2023
@openjdk openjdk bot closed this Jul 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 18, 2023
@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@lahodaj Pushed as commit 7a5d6f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants