Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17 #141

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jul 20, 2023

Backport of JDK-8308103. Applies cleanly.

Thanks,
Tobias


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.org/jdk21.git pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/141.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2023

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c6ab9c2905203e1ec897b3404f9179ff975d0054 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17 Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 20, 2023

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2023
@TobiHartmann
Copy link
Member Author

Thanks, Christian!

@pfustc
Copy link
Member

pfustc commented Jul 20, 2023

This patch causes assertion failure. See https://bugs.openjdk.org/browse/JDK-8312440

@TobiHartmann
Copy link
Member Author

Thanks! I'll close this backport for now then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot-compiler hotspot-compiler-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
4 participants