Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

Conversation

@rgiulietti
Copy link
Contributor

@rgiulietti rgiulietti commented Aug 4, 2023

Hi all,

This pull request contains a backport of commit 61c58fdd from the openjdk/jdk repository.

The commit being backported was authored by Raffaello Giulietti on 4 Aug 2023 and was reviewed by Alan Bateman and Stuart Marks.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/164/head:pull/164
$ git checkout pull/164

Update a local copy of the PR:
$ git checkout pull/164
$ git pull https://git.openjdk.org/jdk21.git pull/164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 164

View PR using the GUI difftool:
$ git pr show -t 164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/164.diff

Webrev

Link to Webrev Comment

@rgiulietti rgiulietti changed the title Backport 61c58fdd00727da2841a052477e4f4ecfa7094d6 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match Aug 4, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@rgiulietti The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 4, 2023
@rgiulietti rgiulietti changed the title 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match Backport 61c58fdd00727da2841a052477e4f4ecfa7094d6 Aug 4, 2023
@openjdk openjdk bot changed the title Backport 61c58fdd00727da2841a052477e4f4ecfa7094d6 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

mlbridge bot commented Aug 4, 2023

Webrevs

@rgiulietti rgiulietti closed this Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant