Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8312814: Compiler crash when template processor type is a captured wildcard #167

Closed

Conversation

JimLaskey
Copy link
Member

@JimLaskey JimLaskey commented Aug 8, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312814: Compiler crash when template processor type is a captured wildcard (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/167/head:pull/167
$ git checkout pull/167

Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.org/jdk21.git pull/167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 167

View PR using the GUI difftool:
$ git pr show -t 167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/167.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2023

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f14245b3880ff735ae231b4c7d2c6b6907c5f7d4 8312814: Compiler crash when template processor type is a captured wildcard Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@JimLaskey The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Aug 8, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2023

Webrevs

@jonathan-gibbons
Copy link
Contributor

Yes, looks the same as the original

Copy link

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312814: Compiler crash when template processor type is a captured wildcard

Reviewed-by: jjg, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2023
@JimLaskey
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

Going to push as commit a073530.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 01a5df6: 8313345: SuperWord fails due to CMove without matching Bool pack

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2023
@openjdk openjdk bot closed this Aug 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@JimLaskey Pushed as commit a073530.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants