Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8309613: [Windows] hs_err files sometimes miss information about the code containing the error #17

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 14, 2023

We need good hs_err files in JDK21 in case a problem like https://bugs.openjdk.org/secure/attachment/103766/hs_err_pid7652.log occurs again.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309613: [Windows] hs_err files sometimes miss information about the code containing the error (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.org/jdk21.git pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/17.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bd79db3930f192f6742e29a63a6d1c3bc3dd3385 8309613: [Windows] hs_err files sometimes miss information about the code containing the error Jun 14, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 14, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 14, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2023

Webrevs

@tstuefe
Copy link
Member

tstuefe commented Jun 14, 2023

Enable tests?

@TheRealMDoerr
Copy link
Contributor Author

Tests are running: https://github.com/TheRealMDoerr/jdk21/actions/runs/5265244923
Unfortunately, some builds didn't work due to other problems. I'll use our internal builds for testing.

@tstuefe
Copy link
Member

tstuefe commented Jun 14, 2023

openjdk/jdk#14448 seems to have helped in HEAD. Maybe we should backport that one.

@TheRealMDoerr
Copy link
Contributor Author

openjdk/jdk#14448 seems to have helped in HEAD. Maybe we should backport that one.

Yes, there's already an open PR: #18

@TheRealMDoerr
Copy link
Contributor Author

Our nightly builds and tests were successful. No regression found.

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309613: [Windows] hs_err files sometimes miss information about the code containing the error

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0ac9275: 8309956: Shenandoah: Strengthen the mark word check in string dedup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

Going to push as commit 07d20dc.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 0ac9275: 8309956: Shenandoah: Strengthen the mark word check in string dedup

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 15, 2023
@openjdk openjdk bot closed this Jun 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@TheRealMDoerr Pushed as commit 07d20dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants