8309934: Update GitHub Actions to use JDK 17 for building jtreg

[sormuras]

Hi all,

This pull request contains a backport of commit 8aad881e from the openjdk/jdk repository.

The commit being backported was authored by Christian Stein on 13 Jun 2023 and was reviewed by Erik Joelsson.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309934: Update GitHub Actions to use JDK 17 for building jtreg (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/jdk21.git pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/18.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@sormuras The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (f543006a)
• 00: Full (ab75266e)

[TheRealMDoerr]

Thanks for backporting! Could you enable GitHub Actions and run the tests, please?

[openjdk]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309934: Update GitHub Actions to use JDK 17 for building jtreg

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sormuras]

Could you enable GitHub Actions and run the tests, please?

I enabled workflows on the fork the bot created for me - how do I trigger a run now? Manually via https://github.com/openjdk-bots/jdk21/actions/workflows/main.yml and use the default linux-x64, linux-x86, linux-x64-variants, linux-cross-compile, macos-x64, macos-aarch64, windows-x64, windows-aarch64, docs platforms?

[TheRealMDoerr]

Yes. You can post the link to the results, here.

[sormuras]

Results are linked and look good: https://github.com/openjdk-bots/jdk21/actions/runs/5270919104

But, the issue still appears after updating to use the pre-installed JDK 17:

Note: the underlying issue is not fixed, I think.
Just got the same GHA failure with 17u:

 C:/hostedtoolcache/windows/Java_Temurin-Hotspot_jdk/17.0.7-7/x64/bin/java -cp > "D:/a/lilliput/lilliput/jtreg/src/build/classes;D:/a/lilliput/lilliput/jtreg/src/build/deps/jtharness/build/binaries/lib/javatest.jar" \
    -Dprogram=jtreg com.sun.javatest.regtest.Main -help all > D:/a/lilliput/lilliput/jtreg/src/build/jtreg-usage.txt
/bin/sh: line 1: C:/hostedtoolcache/windows/Java_Temurin-Hotspot_jdk/17.0.7-7/x64/bin/javac: Bad address

Thus, I'll close this backport PR and work on finding a better fix the underlying issue.
See https://bugs.openjdk.org/browse/JDK-8309934 and a follow-up issue for details.