Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads #20

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jun 15, 2023

Clean backport to jdk21, fixes misaligned access in string.IndexOf intrinsic, significantly improves performance of intrinsic on hardware without misaligned access support


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/20/head:pull/20
$ git checkout pull/20

Update a local copy of the PR:
$ git checkout pull/20
$ git pull https://git.openjdk.org/jdk21.git pull/20/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20

View PR using the GUI difftool:
$ git pr show -t 20

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/20.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2023

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6b942893868fa1a64977288bdbdb1bbff8bd9d9c 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@VladimirKempik The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 15, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2023

Webrevs

@VladimirKempik
Copy link
Author

windows and linux x86 failures unrelated, this patch changes only RISC-V specific code, nothing outside of risc-v

@kevinrushforth
Copy link
Member

Since this is an Enhancement, you will need approval to backport this to JDK 21 during RDP1. See the "Late-Enhancement Request Process" section of JEP 3.

@VladimirKempik
Copy link
Author

OKay, I will try with 21.0.1 then

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review
2 participants