Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8303916: ThreadLists.java inconsistent results #24

Closed

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jun 16, 2023

Clean backport from latest jdk repo to jdk21 for the test change:
8303916: ThreadLists.java inconsistent results


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303916: ThreadLists.java inconsistent results (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jdk21.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/24.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8c9b85a990d955487f9141207cc83d0051defc57 8303916: ThreadLists.java inconsistent results Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@kevinjwalls The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

@kevinjwalls
Copy link
Contributor Author

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@kevinjwalls
The core-libs label was successfully removed.

@AlanBateman
Copy link

/label remove core-libs

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@AlanBateman The core-libs label was not set.

Copy link

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport looks clean.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303916: ThreadLists.java inconsistent results

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • beb0d95: 8310054: ScrollPane insets are incorrect
  • e0cc401: 8310019: MIPS builds are broken after JDK-8304913
  • 7e78893: 8310105: LoongArch64 builds are broken after JDK-8304913
  • fb6f5f1: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • 7ca0f14: 8309957: Rename JDK-8309595 test to conform
  • bfffd8b: 8309595: Allow javadoc to process unnamed classes
  • ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
  • 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
  • e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • 14c5091: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
  • ... and 6 more: https://git.openjdk.org/jdk21/compare/39e98e7bbf278b8772350fd28d2bd8ad8cb06315...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2023
@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2023

Going to push as commit 8d9ebb6.
Since your change was applied there have been 49 commits pushed to the master branch:

  • 0903c8d: 8310194: Generational ZGC: Lock-order asserts in JVMTI IterateThroughHeap
  • 9998c07: 8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation
  • 3248dae: 8310830: typo in the parameter name in @throws of ClassDesc::ofDescriptor
  • 033060b: 8310975: java.util.FormatItemModifier should not be protected
  • df26258: 8310182: DateTimeFormatter date formats (ISO_LOCAL_DATE) separated with hyphen, not dash
  • 087d4a8: 8309258: RISC-V: Add riscv_hwprobe syscall
  • 6a4552c: 8310242: Clarify the name parameter to Class::forName
  • 71a41f7: 8310861: Improve location reporting for javac serial lint warnings
  • cdb8c70: 8309670: java -help output for --module-path / -p is incomplete
  • 8748b46: 8309471: Limit key characters in static index pages
  • ... and 39 more: https://git.openjdk.org/jdk21/compare/39e98e7bbf278b8772350fd28d2bd8ad8cb06315...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2023
@openjdk openjdk bot closed this Jun 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@kevinjwalls Pushed as commit 8d9ebb6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants