8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

[jianglizhou]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries (Enhancement - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/jdk21.git pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/26.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jianglizhou The following labels will be automatically applied to this pull request:

• build
• client
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (13592e4b)

[kevinrushforth]

As a P4 enhancement, this doesn't meet the criteria for integration into JDK 21 during Rampdown Phase 1. You could request late approval to get this enhancement in, via the process described in JEP 3.

[jianglizhou]

As a P4 enhancement, this doesn't meet the criteria for integration into JDK 21 during Rampdown Phase 1. You could request late approval to get this enhancement in, via the process described in JEP 3.

Thanks for the pointer, @kevinrushforth. Will follow the process.

[dcubed-ojdk]

GHA is failing on windows; is this related to this PR or something else?

[dcubed-ojdk]

@erikj - You did a round of Mach5 testing on the JDK22 version of this fix. Do you
have plans to redo that testing for the JDK21 backport?

[jianglizhou]

GHA is failing on windows; is this related to this PR or something else?

The windows build failures occur with other PRs as well, e.g. https://github.com/openjdk/jdk21/pull/24/checks?check_run_id=14317258603. They should be unrelated.

make: *** [jtdiff.gmk:36: D:/a/jdk21/jdk21/jtreg/src/build/classes.com.sun.javatest.diff.ok] Error 126
Error: Process completed with exit code 2.

I noticed these presubmit failures with jdk started since last week or so.

[erikj79]

@erikj - You did a round of Mach5 testing on the JDK22 version of this fix. Do you have plans to redo that testing for the JDK21 backport?

I have done testing of the JDK 21 version of the patch and it's running cleanly.

[erikj79]

The changes look ok.

[openjdk]

@jianglizhou This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 7e78893: 8310105: LoongArch64 builds are broken after JDK-8304913
• fb6f5f1: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
• 7ca0f14: 8309957: Rename JDK-8309595 test to conform
• bfffd8b: 8309595: Allow javadoc to process unnamed classes
• ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
• 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
• e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
• 14c5091: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
• 36e3fe9: 8309928: JFR: View issues
• 4d81b89: 8309960: ParallelGC young collections very slow in DelayInducer
• ... and 3 more: https://git.openjdk.org/jdk21/compare/aced11446ea0b80568bb1139a257927cc57af376...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jianglizhou]

@erikj - You did a round of Mach5 testing on the JDK22 version of this fix. Do you have plans to redo that testing for the JDK21 backport?

I have done testing of the JDK 21 version of the patch and it's running cleanly.

Thanks for testing, @erikj79!

[jianglizhou]

The changes look ok.

Thanks. I'll wait for approval on https://bugs.openjdk.org/browse/JDK-8307858 as well.

[kevinrushforth]

Since this Enhancement was rejected for JDK 21, this PR should be closed.

[jianglizhou]

Since this Enhancement was rejected for JDK 21, this PR should be closed.

Closing without integration accordingly, thanks.