Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8309471: Limit key characters in static index pages #30

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Jun 19, 2023

Backport of openjdk/jdk#14312 to limit first character keys in the static JavaDoc index pages to valid Java identifier start characters.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309471: Limit key characters in static index pages (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.org/jdk21.git pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/30.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Jun 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Jun 19, 2023

@hns Since this is a backport, you should change the title of this PR to: Backport COMMITHASH where COMMITHASH is the 40 character hash of the mainline jdk commit, 21f6d83358458c2e5a6cc1bc19a6a33b3262f990 in this case.

@hns hns changed the title JDK-8309471: Limit key characters in static index pages Backport 21f6d83358458c2e5a6cc1bc19a6a33b3262f990 Jun 20, 2023
@openjdk openjdk bot changed the title Backport 21f6d83358458c2e5a6cc1bc19a6a33b3262f990 8309471: Limit key characters in static index pages Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309471: Limit key characters in static index pages

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 63d419e: 8310868: Thread.interrupt() method's javadoc has an incorrect {@link}
  • f0e80fa: 8309959: JFR: Display N/A for missing data amount
  • 7489967: 8310676: add note about unnamed module to Elements.getAllModuleElements
  • 17b6f7b: 8309740: Expand timeout windows for tests in JDK-8179502
  • af3a56e: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64
  • 1bcf001: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • 8b12726: 8304885: Reuse stale data to improve DNS resolver resiliency
  • e86d765: 8309853: StructuredTaskScope.join description improvements
  • 2f1af3c: 8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent
  • 6317249: 8310187: Improve Generational ZGC jtreg testing
  • ... and 25 more: https://git.openjdk.org/jdk21/compare/ace56237d39eaa67b37456d2af8cf71664815987...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 26, 2023
@hns
Copy link
Member Author

hns commented Jun 26, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

Going to push as commit 8748b46.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 63d419e: 8310868: Thread.interrupt() method's javadoc has an incorrect {@link}
  • f0e80fa: 8309959: JFR: Display N/A for missing data amount
  • 7489967: 8310676: add note about unnamed module to Elements.getAllModuleElements
  • 17b6f7b: 8309740: Expand timeout windows for tests in JDK-8179502
  • af3a56e: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64
  • 1bcf001: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • 8b12726: 8304885: Reuse stale data to improve DNS resolver resiliency
  • e86d765: 8309853: StructuredTaskScope.join description improvements
  • 2f1af3c: 8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent
  • 6317249: 8310187: Improve Generational ZGC jtreg testing
  • ... and 25 more: https://git.openjdk.org/jdk21/compare/ace56237d39eaa67b37456d2af8cf71664815987...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2023
@openjdk openjdk bot closed this Jun 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@hns Pushed as commit 8748b46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
3 participants