Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8310054: ScrollPane insets are incorrect #33

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Jun 19, 2023

This pull request contains a backport of commit d6c2ee34 from the openjdk/jdk repository.

It fixes the regression introduced by JDK-8297923.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310054: ScrollPane insets are incorrect (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.org/jdk21.git pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/33.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d6c2ee3448a14b3e5a392aacc11ed8e47d388f80 8310054: ScrollPane insets are incorrect Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

Copy link

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport. Changes look good.

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310054: ScrollPane insets are incorrect

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 7e78893: 8310105: LoongArch64 builds are broken after JDK-8304913
  • fb6f5f1: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • 7ca0f14: 8309957: Rename JDK-8309595 test to conform
  • bfffd8b: 8309595: Allow javadoc to process unnamed classes
  • ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
  • 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
  • e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • 14c5091: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 20, 2023
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

Going to push as commit beb0d95.
Since your change was applied there have been 9 commits pushed to the master branch:

  • e0cc401: 8310019: MIPS builds are broken after JDK-8304913
  • 7e78893: 8310105: LoongArch64 builds are broken after JDK-8304913
  • fb6f5f1: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • 7ca0f14: 8309957: Rename JDK-8309595 test to conform
  • bfffd8b: 8309595: Allow javadoc to process unnamed classes
  • ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
  • 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
  • e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • 14c5091: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2023
@openjdk openjdk bot closed this Jun 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@aivanov-jdk Pushed as commit beb0d95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants