Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8309937: Add @sealedGraph for some Panama FFM interfaces #34

Closed

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Jun 19, 2023

Hi all,

This pull request contains a backport of commit b412fc79 from the openjdk/jdk repository.

The commit being backported was authored by Per Minborg on 16 Jun 2023 and was reviewed by Maurizio Cimadamore.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309937: Add @sealedGraph for some Panama FFM interfaces (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/34/head:pull/34
$ git checkout pull/34

Update a local copy of the PR:
$ git checkout pull/34
$ git pull https://git.openjdk.org/jdk21.git pull/34/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 34

View PR using the GUI difftool:
$ git pr show -t 34

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/34.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b412fc79c3c2548df10918090beedaf6b2d08d96 8309937: Add @sealedGraph for some Panama FFM interfaces Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

@kevinrushforth
Copy link
Member

Since this is a P4 Enhancement, you will need approval to backport this to JDK 21 during RDP1. See the "Late-Enhancement Request Process" section of JEP 3.

@mcimadamore
Copy link
Contributor

Since this is a P4 Enhancement, you will need approval to backport this to JDK 21 during RDP1. See the "Late-Enhancement Request Process" section of JEP 3.

Test and documentation bugs and enhancements

Bugs and enhancements of any priority that only affect tests, or test-problem lists, or documentation may be addressed in RDP 1 and RDP 2. You don’t need to request approval for such a change in order to integrate it, but please do make sure that the issue has a [noreg-self or noreg-doc label](https://openjdk.org/guide/#noreg), as appropriate.

@minborg
Copy link
Contributor Author

minborg commented Jun 20, 2023

The issue has a label noreg-doc so we should be able to integrate this PR.

@kevinrushforth
Copy link
Member

Now that it has a noreg-doc label it is fine.

@minborg
Copy link
Contributor Author

minborg commented Jun 21, 2023

Yes. I recently added it. Please review.

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309937: Add @sealedGraph for some Panama FFM interfaces

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 60cae33: 8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX
  • beb0d95: 8310054: ScrollPane insets are incorrect
  • e0cc401: 8310019: MIPS builds are broken after JDK-8304913
  • 7e78893: 8310105: LoongArch64 builds are broken after JDK-8304913
  • fb6f5f1: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • 7ca0f14: 8309957: Rename JDK-8309595 test to conform
  • bfffd8b: 8309595: Allow javadoc to process unnamed classes
  • ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
  • 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
  • e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • ... and 6 more: https://git.openjdk.org/jdk21/compare/aced11446ea0b80568bb1139a257927cc57af376...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2023
@minborg
Copy link
Contributor Author

minborg commented Jun 21, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

Going to push as commit ef0357f.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 60cae33: 8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX
  • beb0d95: 8310054: ScrollPane insets are incorrect
  • e0cc401: 8310019: MIPS builds are broken after JDK-8304913
  • 7e78893: 8310105: LoongArch64 builds are broken after JDK-8304913
  • fb6f5f1: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • 7ca0f14: 8309957: Rename JDK-8309595 test to conform
  • bfffd8b: 8309595: Allow javadoc to process unnamed classes
  • ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
  • 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
  • e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • ... and 6 more: https://git.openjdk.org/jdk21/compare/aced11446ea0b80568bb1139a257927cc57af376...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2023
@openjdk openjdk bot closed this Jun 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@minborg Pushed as commit ef0357f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants