Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING #43

Closed

Conversation

sspitsyn
Copy link

@sspitsyn sspitsyn commented Jun 21, 2023

Clean backport from latest jdk repo to jdk21 for the fix of:
8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

Testing:

  • TBD: mach5 tiers 1-5

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/43/head:pull/43
$ git checkout pull/43

Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.org/jdk21.git pull/43/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 43

View PR using the GUI difftool:
$ git pr show -t 43

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/43.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@sspitsyn The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

@kevinrushforth
Copy link
Member

NOTE: if you change the PR title to Backport COMMITHASH as suggested by Skara in the Issue section of the PR description, Skara will be able to verify whether the backport is clean, and also mark it as a Backport.

@sspitsyn sspitsyn changed the title 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING Backport f91e9ba Jun 21, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 21, 2023
@sspitsyn
Copy link
Author

NOTE: if you change the PR title to Backport COMMITHASH as suggested by Skara in the Issue section of the PR description, Skara will be able to verify whether the backport is clean, and also mark it as a Backport.

Thank you, Kevin. It seems, I've done a typical mistake.

@kevinrushforth
Copy link
Member

It needs to be the full 40 character hash.

@sspitsyn sspitsyn changed the title Backport f91e9ba Backport f91e9ba757f04983655c23542e06973805465249 Jun 21, 2023
@openjdk openjdk bot changed the title Backport f91e9ba757f04983655c23542e06973805465249 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 21, 2023
@sspitsyn
Copy link
Author

It needs to be the full 40 character hash.

Thanks! It helped now.

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 722b512: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException
  • a4159dd: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • 3985a4d: 8310053: VarHandle and slice handle derived from layout are lacking alignment check
  • 1fc6042: 8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX
  • ef0357f: 8309937: Add @sealedGraph for some Panama FFM interfaces
  • 60cae33: 8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2023
@sspitsyn
Copy link
Author

Thank you for review, Chris!

@sspitsyn
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

Going to push as commit f8a38ee.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 722b512: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException
  • a4159dd: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • 3985a4d: 8310053: VarHandle and slice handle derived from layout are lacking alignment check
  • 1fc6042: 8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX
  • ef0357f: 8309937: Add @sealedGraph for some Panama FFM interfaces
  • 60cae33: 8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2023
@openjdk openjdk bot closed this Jun 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@sspitsyn Pushed as commit f8a38ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn sspitsyn deleted the sspitsyn-backport-f91e9ba7 branch June 22, 2023 03:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants