8302865: Illegal bytecode for break from if with instanceof pattern matching condition

[lahodaj]

Hi all,

This pull request contains a backport of commit a15db1a5 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 21 Jun 2023 and was reviewed by Vicente Romero.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8310016 to be approved

Issues

• JDK-8302865: Illegal bytecode for break from if with instanceof pattern matching condition (Bug - P3)
• JDK-8310016: Illegal bytecode for break from if with instanceof pattern matching condition (CSR)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.org/jdk21.git pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/47.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d82277af)

[vicente-romero-oracle]

looks good

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302865: Illegal bytecode for break from if with instanceof pattern matching condition

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• a4159dd: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
• 3985a4d: 8310053: VarHandle and slice handle derived from layout are lacking alignment check

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 789b2fc.
Since your change was applied there have been 5 commits pushed to the master branch:

• ceadaec: 8310133: Effectivelly final condition not enforced in guards for binding variables from the same case
• f8a38ee: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
• 722b512: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException
• a4159dd: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
• 3985a4d: 8310053: VarHandle and slice handle derived from layout are lacking alignment check

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 789b2fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.