Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8309959: JFR: Display N/A for missing data amount #56

Closed

Conversation

fthevenet
Copy link
Member

@fthevenet fthevenet commented Jun 22, 2023

Hi!

This pull request contains a backport of commit 9872a141 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 14 Jun 2023 and was reviewed by Markus Grönlund and Thomas Stuefe.

This is a follow-up to JDK-8309550 which was integrated before RDP1, so backporting this one also as a matter of consistency.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309959: JFR: Display N/A for missing data amount (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/56/head:pull/56
$ git checkout pull/56

Update a local copy of the PR:
$ git checkout pull/56
$ git pull https://git.openjdk.org/jdk21.git pull/56/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 56

View PR using the GUI difftool:
$ git pr show -t 56

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/56.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2023

👋 Welcome back fthevenet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9872a14192ce3964b934c19ab685342ffd396986 8309959: JFR: Display N/A for missing data amount Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 22, 2023
@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@fthevenet The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jun 22, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@fthevenet This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309959: JFR: Display N/A for missing data amount

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 7489967: 8310676: add note about unnamed module to Elements.getAllModuleElements
  • 17b6f7b: 8309740: Expand timeout windows for tests in JDK-8179502
  • af3a56e: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64
  • 1bcf001: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • 8b12726: 8304885: Reuse stale data to improve DNS resolver resiliency
  • e86d765: 8309853: StructuredTaskScope.join description improvements

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@egahlin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2023
@fthevenet
Copy link
Member Author

Hello @egahlin
I am unsure if I need to request approval by setting a jdk21-fix-request label on the JBS issue before integrating this into a stabilization repository like I would for an update repo; can you, or anybody else, please advise?
Thanks!

@egahlin
Copy link
Member

egahlin commented Jun 22, 2023

Hello @egahlin
I am unsure if I need to request approval by setting a jdk21-fix-request label on the JBS issue before integrating this into a stabilization repository like I would for an update repo; can you, or anybody else, please advise?
Thanks!

We are still in Rampdown Phase One and it's a P3. It can be backported without a fix-request.

https://openjdk.org/jeps/3#rdp-1

@fthevenet
Copy link
Member Author

Hello @egahlin
I am unsure if I need to request approval by setting a jdk21-fix-request label on the JBS issue before integrating this into a stabilization repository like I would for an update repo; can you, or anybody else, please advise?
Thanks!

We are still in Rampdown Phase One and it's a P3. It can be backported without a fix-request.

https://openjdk.org/jeps/3#rdp-1

Thanks @egahlin

@fthevenet
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@fthevenet
Your change (at version 7d80515) is now ready to be sponsored by a Committer.

@egahlin
Copy link
Member

egahlin commented Jun 26, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

Going to push as commit f0e80fa.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7489967: 8310676: add note about unnamed module to Elements.getAllModuleElements
  • 17b6f7b: 8309740: Expand timeout windows for tests in JDK-8179502
  • af3a56e: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64
  • 1bcf001: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • 8b12726: 8304885: Reuse stale data to improve DNS resolver resiliency
  • e86d765: 8309853: StructuredTaskScope.join description improvements

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2023
@openjdk openjdk bot closed this Jun 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@egahlin @fthevenet Pushed as commit f0e80fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants