Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64 #60

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 23, 2023

A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/60/head:pull/60
$ git checkout pull/60

Update a local copy of the PR:
$ git checkout pull/60
$ git pull https://git.openjdk.org/jdk21.git pull/60/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 60

View PR using the GUI difftool:
$ git pr show -t 60

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/60.diff

Webrev

Link to Webrev Comment

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@dcubed-ojdk
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 23, 2023

Webrevs

@@ -28,3 +28,4 @@
#############################################################################

java/lang/invoke/MethodHandles/CatchExceptionTest.java 8146623 generic-all
java/lang/ScopedValue/StressStackOverflow.java 8308609 generic-x64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java/lang/ScopedValue/StressStackOverflow.java#no-vmcontinuations ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. This is the JDK21 version of the test and not the JDK22 version of the test.

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64

Reviewed-by: iris, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1bcf001: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 23, 2023
@dcubed-ojdk
Copy link
Member Author

@irisclark and @lmesnik - Thanks for the fast reviews!

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit af3a56e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 1bcf001: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@dcubed-ojdk Pushed as commit af3a56e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8310822 branch June 24, 2023 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants