Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation #68

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jun 27, 2023

Backport of JDK-8310459. Applies cleanly.

Thanks,
Tobias


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/68/head:pull/68
$ git checkout pull/68

Update a local copy of the PR:
$ git checkout pull/68
$ git pull https://git.openjdk.org/jdk21.git pull/68/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 68

View PR using the GUI difftool:
$ git pr show -t 68

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/68.diff

Webrev

Link to Webrev Comment

…entation

Reviewed-by: thartmann, sviswanathan
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2023

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ff9a7541097bd853306a8594c97774f36877a0f9 8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation Jun 27, 2023
@openjdk
Copy link

openjdk bot commented Jun 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 27, 2023
@openjdk
Copy link

openjdk bot commented Jun 27, 2023

@TobiHartmann The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jun 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2023

Webrevs

Copy link

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Jun 27, 2023

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 087d4a8: 8309258: RISC-V: Add riscv_hwprobe syscall

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2023
@TobiHartmann
Copy link
Member Author

Thanks, Vladimir!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2023

Going to push as commit 9998c07.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 3248dae: 8310830: typo in the parameter name in @throws of ClassDesc::ofDescriptor
  • 033060b: 8310975: java.util.FormatItemModifier should not be protected
  • df26258: 8310182: DateTimeFormatter date formats (ISO_LOCAL_DATE) separated with hyphen, not dash
  • 087d4a8: 8309258: RISC-V: Add riscv_hwprobe syscall

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2023
@openjdk openjdk bot closed this Jun 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2023
@openjdk
Copy link

openjdk bot commented Jun 28, 2023

@TobiHartmann Pushed as commit 9998c07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants