Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8310656: RISC-V: __builtin___clear_cache can fail silently. #90

Closed
wants to merge 2 commits into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Jul 2, 2023

Hi all,

This pull request contains a backport of commit faf1b822 from the openjdk/jdk repository.

The commit being backported was authored by Robbin Ehn on 2 Jul 2023 and was reviewed by Ludovic Henry, Thomas Stuefe and Fei Yang.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310656: RISC-V: __builtin___clear_cache can fail silently. (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/90/head:pull/90
$ git checkout pull/90

Update a local copy of the PR:
$ git checkout pull/90
$ git pull https://git.openjdk.org/jdk21.git pull/90/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 90

View PR using the GUI difftool:
$ git pr show -t 90

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/90.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2023

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport faf1b822d03b726413d77a2b247dfbbf4db7d57e 8310656: RISC-V: __builtin___clear_cache can fail silently. Jul 2, 2023
@openjdk
Copy link

openjdk bot commented Jul 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 2, 2023
@openjdk
Copy link

openjdk bot commented Jul 2, 2023

@robehn The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 2, 2023

Webrevs

@robehn
Copy link
Contributor Author

robehn commented Jul 5, 2023

It have a dependency on a enhancement in 22, I'll fix that. (rv64 do not build)

@robehn
Copy link
Contributor Author

robehn commented Jul 6, 2023

I missed clicking yes on collab in time, so I can't push to this branch.

It seems I'm in some limbo, maybe @zhaosongzs can me help?

@robehn robehn closed this Jul 6, 2023
@robehn robehn reopened this Jul 6, 2023
@zhaosongzs
Copy link
Member

I missed clicking yes on collab in time, so I can't push to this branch.

It seems I'm in some limbo, maybe @zhaosongzs can me help?

Just back from lunch. Let me have a try.

@zhaosongzs
Copy link
Member

I missed clicking yes on collab in time, so I can't push to this branch.

It seems I'm in some limbo, maybe @zhaosongzs can me help?

Ah, I have invited you to be a collaborator in openjdk-bots/jdk21

Signed-off-by: Robbin Ehn <rehn@rivosinc.com>
@robehn
Copy link
Contributor Author

robehn commented Jul 6, 2023

I missed clicking yes on collab in time, so I can't push to this branch.
It seems I'm in some limbo, maybe @zhaosongzs can me help?

Ah, I have invited you to be a collaborator in openjdk-bots/jdk21

Thank you. But I still get perm denied :)
I guess I'm doing something wrong?

[rehn@rehn jdk21]$ git remote -vv
origin	ssh://github.com/openjdk-bots/jdk21 (fetch)
origin	ssh://github.com/openjdk-bots/jdk21 (push)
[rehn@rehn jdk21]$ git branch -vv
  master                   aced11446ea [origin/master] 8310128: Switch with unnamed patterns erroneously non-exhaustive
* robehn-backport-faf1b822 be7724a44e0 [origin/robehn-backport-faf1b822: ahead 1] Added missing global defines in jdk 21
[rehn@rehn jdk21]$ git push
Enter passphrase for key '/home/rehn/.ssh/github': 
ERROR: Permission to openjdk-bots/jdk21.git denied to robehn.

@zhaosongzs
Copy link
Member

I missed clicking yes on collab in time, so I can't push to this branch.
It seems I'm in some limbo, maybe @zhaosongzs can me help?

Ah, I have invited you to be a collaborator in openjdk-bots/jdk21

Thank you. But I still get perm denied :) I guess I'm doing something wrong?

[rehn@rehn jdk21]$ git remote -vv
origin	ssh://github.com/openjdk-bots/jdk21 (fetch)
origin	ssh://github.com/openjdk-bots/jdk21 (push)
[rehn@rehn jdk21]$ git branch -vv
  master                   aced11446ea [origin/master] 8310128: Switch with unnamed patterns erroneously non-exhaustive
* robehn-backport-faf1b822 be7724a44e0 [origin/robehn-backport-faf1b822: ahead 1] Added missing global defines in jdk 21
[rehn@rehn jdk21]$ git push
Enter passphrase for key '/home/rehn/.ssh/github': 
ERROR: Permission to openjdk-bots/jdk21.git denied to robehn.

Have you accepted the invitation? From what I can see, the invitation is still pending.

@robehn
Copy link
Contributor Author

robehn commented Jul 6, 2023

I missed clicking yes on collab in time, so I can't push to this branch.
It seems I'm in some limbo, maybe @zhaosongzs can me help?

Ah, I have invited you to be a collaborator in openjdk-bots/jdk21

Thank you. But I still get perm denied :) I guess I'm doing something wrong?

[rehn@rehn jdk21]$ git remote -vv
origin	ssh://github.com/openjdk-bots/jdk21 (fetch)
origin	ssh://github.com/openjdk-bots/jdk21 (push)
[rehn@rehn jdk21]$ git branch -vv
  master                   aced11446ea [origin/master] 8310128: Switch with unnamed patterns erroneously non-exhaustive
* robehn-backport-faf1b822 be7724a44e0 [origin/robehn-backport-faf1b822: ahead 1] Added missing global defines in jdk 21
[rehn@rehn jdk21]$ git push
Enter passphrase for key '/home/rehn/.ssh/github': 
ERROR: Permission to openjdk-bots/jdk21.git denied to robehn.

Have you accepted the invitation? From what I can see, the invitation is still pending.

I clicked on a check mark :) Maybe it takes a while for it to progate in the "eventually consistent world".

@openjdk openjdk bot removed the clean label Jul 6, 2023
@robehn
Copy link
Contributor Author

robehn commented Jul 7, 2023

@tstuefe @luhenry @RealFYang any takers ? :)

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310656: RISC-V: __builtin___clear_cache can fail silently.

Reviewed-by: luhenry, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 99ae133: 8308585: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required
  • 413ee9f: 8309761: Leak class loader constraints
  • 773bb0a: 8311183: Remove unused mapping test files
  • 6ef8016: 8310265: (process) jspawnhelper should not use argv[0]
  • 2d7ed18: 8295210: IR framework should not whitelist -XX:-UseTLAB
  • 98ad856: 8309140: ResourceHashtable failed "assert(~(_allocation_t[0] | allocation_mask) == (uintptr_t)this) failed: lost resource object"
  • 830279e: 8310425: [JVMCI] compiler/runtime/TestConstantDynamic: lookupConstant returned an object of incorrect type: null
  • fb7fd58: 8311264: JavaDoc index comparator is not transitive
  • bfed32b: 8311122: Fix typos in java.base
  • c86f4de: 8311023: assert(false) failed: EA: missing memory path
  • ... and 8 more: https://git.openjdk.org/jdk21/compare/8088bc4033884adbd249ae9eb92c3ad1b81a69da...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2023
@robehn
Copy link
Contributor Author

robehn commented Jul 13, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

Going to push as commit 5f1d762.
Since your change was applied there have been 28 commits pushed to the master branch:

  • f6ad56b: 8308694: Clarify reversed() default methods' implementation requirements
  • 82c8b28: 8156889: ListKeychainStore.sh fails in some virtualized environments
  • 72cf3c9: 8295894: Remove SECOM certificate that is expiring in September 2023
  • dd48ed8: 8309637: runtime/handshake/HandshakeTimeoutTest.java fails with "has not cleared handshake op" and SIGILL
  • 3bb3750: 8310892: ScopedValue throwing StructureViolationException should be clearer
  • ca10804: 8311593: Minor doc issue in MemorySegment::copy
  • 480dc22: 8311689: Wrong visible amount in Adjustable of ScrollPane
  • 308b4c6: 8302351: "assert(!JavaThread::current()->is_interp_only_mode() || !nm->method()->is_continuation_enter_intrinsic() || ContinuationEntry::is_interpreted_call(return_pc)) failed: interp_only_mode but not in enterSpecial interpreted entry" in fixup_callers_callsite
  • c97db0d: 8311245: JFR: Remove t.printStackTrace() in PeriodicEvents
  • 8808ec3: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
  • ... and 18 more: https://git.openjdk.org/jdk21/compare/8088bc4033884adbd249ae9eb92c3ad1b81a69da...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 13, 2023
@openjdk openjdk bot closed this Jul 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@robehn Pushed as commit 5f1d762.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants