-
Notifications
You must be signed in to change notification settings - Fork 68
8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit #91
Conversation
…tion::doit Reviewed-by: never, kvn
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@TobiHartmann The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks, Christian! |
/integrate |
Going to push as commit 6de4e8f. |
@TobiHartmann Pushed as commit 6de4e8f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8310829. Applies cleanly.
Thanks,
Tobias
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/91/head:pull/91
$ git checkout pull/91
Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.org/jdk21.git pull/91/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 91
View PR using the GUI difftool:
$ git pr show -t 91
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/91.diff
Webrev
Link to Webrev Comment