Skip to content

Commit 3050bf3

Browse files
Sonia Zaldana Callesshipilev
authored andcommitted
8159927: Add a test to verify JMOD files created in the images do not have debug symbols
Backport-of: 6c0bebccb0092d9726eb89a054e023e92edf7ca6
1 parent 5694ad2 commit 3050bf3

File tree

1 file changed

+76
-0
lines changed

1 file changed

+76
-0
lines changed
Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
/*
2+
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* This code is free software; you can redistribute it and/or modify it
6+
* under the terms of the GNU General Public License version 2 only, as
7+
* published by the Free Software Foundation.
8+
*
9+
* This code is distributed in the hope that it will be useful, but WITHOUT
10+
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11+
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12+
* version 2 for more details (a copy is included in the LICENSE file that
13+
* accompanied this code).
14+
*
15+
* You should have received a copy of the GNU General Public License version
16+
* 2 along with this work; if not, write to the Free Software Foundation,
17+
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18+
*
19+
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20+
* or visit www.oracle.com if you need additional information or have any
21+
* questions.
22+
*/
23+
24+
/**
25+
* @test
26+
* @bug 8159927
27+
* @modules java.base/jdk.internal.util
28+
* @run main JmodExcludedFiles
29+
* @summary Test that JDK JMOD files do not include native debug symbols
30+
*/
31+
32+
import java.nio.file.DirectoryStream;
33+
import java.nio.file.Files;
34+
import java.nio.file.Path;
35+
import java.util.zip.ZipEntry;
36+
import java.util.zip.ZipFile;
37+
import jdk.internal.util.OperatingSystem;
38+
39+
public class JmodExcludedFiles {
40+
public static void main(String[] args) throws Exception {
41+
String javaHome = System.getProperty("java.home");
42+
Path jmods = Path.of(javaHome, "jmods");
43+
try (DirectoryStream<Path> stream = Files.newDirectoryStream(jmods, "*.jmod")) {
44+
for (Path jmodFile : stream) {
45+
try (ZipFile zip = new ZipFile(jmodFile.toFile())) {
46+
if (zip.stream().map(ZipEntry::getName)
47+
.anyMatch(JmodExcludedFiles::isNativeDebugSymbol)) {
48+
throw new RuntimeException(jmodFile + " is expected not to include native debug symbols");
49+
}
50+
}
51+
}
52+
}
53+
}
54+
55+
private static boolean isNativeDebugSymbol(String name) {
56+
int index = name.indexOf("/");
57+
if (index < 0) {
58+
throw new RuntimeException("unexpected entry name: " + name);
59+
}
60+
String section = name.substring(0, index);
61+
if (section.equals("lib") || section.equals("bin")) {
62+
if (OperatingSystem.isMacOS()) {
63+
String n = name.substring(index+1);
64+
int i = n.indexOf("/");
65+
if (i != -1) {
66+
return n.substring(0, i).endsWith(".dSYM");
67+
}
68+
}
69+
return name.endsWith(".diz")
70+
|| name.endsWith(".debuginfo")
71+
|| name.endsWith(".map")
72+
|| name.endsWith(".pdb");
73+
}
74+
return false;
75+
}
76+
}

0 commit comments

Comments
 (0)