Skip to content

Commit 6c1e127

Browse files
Satyen Subramaniamshipilev
Satyen Subramaniam
authored andcommitted
8338202: Shenandoah: Improve handshake closure labels
Backport-of: ba69ed7c58fcf99ed18dfd8840125ddcac9460bb
1 parent 7a25ef2 commit 6c1e127

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -806,7 +806,7 @@ void ShenandoahConcurrentGC::op_weak_roots() {
806806
// Perform handshake to flush out dead oops
807807
{
808808
ShenandoahTimingsTracker t(ShenandoahPhaseTimings::conc_weak_roots_rendezvous);
809-
heap->rendezvous_threads();
809+
heap->rendezvous_threads("Shenandoah Concurrent Weak Roots");
810810
}
811811
}
812812

src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ class ShenandoahFlushSATBHandshakeClosure : public HandshakeClosure {
186186
SATBMarkQueueSet& _qset;
187187
public:
188188
ShenandoahFlushSATBHandshakeClosure(SATBMarkQueueSet& qset) :
189-
HandshakeClosure("Shenandoah Flush SATB Handshake"),
189+
HandshakeClosure("Shenandoah Flush SATB"),
190190
_qset(qset) {}
191191

192192
void do_thread(Thread* thread) {

src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -1568,12 +1568,12 @@ class ShenandoahInitMarkUpdateRegionStateClosure : public ShenandoahHeapRegionCl
15681568

15691569
class ShenandoahRendezvousClosure : public HandshakeClosure {
15701570
public:
1571-
inline ShenandoahRendezvousClosure() : HandshakeClosure("ShenandoahRendezvous") {}
1571+
inline ShenandoahRendezvousClosure(const char* name) : HandshakeClosure(name) {}
15721572
inline void do_thread(Thread* thread) {}
15731573
};
15741574

1575-
void ShenandoahHeap::rendezvous_threads() {
1576-
ShenandoahRendezvousClosure cl;
1575+
void ShenandoahHeap::rendezvous_threads(const char* name) {
1576+
ShenandoahRendezvousClosure cl(name);
15771577
Handshake::execute(&cl);
15781578
}
15791579

src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ class ShenandoahHeap : public CollectedHeap {
374374
void update_heap_region_states(bool concurrent);
375375
void rebuild_free_set(bool concurrent);
376376

377-
void rendezvous_threads();
377+
void rendezvous_threads(const char* name);
378378
void recycle_trash();
379379
public:
380380
void notify_gc_progress() { _progress_last_gc.set(); }

src/hotspot/share/gc/shenandoah/shenandoahUnload.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ void ShenandoahUnload::unload() {
171171
// Make sure stale metadata and nmethods are no longer observable
172172
{
173173
ShenandoahTimingsTracker t(ShenandoahPhaseTimings::conc_class_unload_rendezvous);
174-
heap->rendezvous_threads();
174+
heap->rendezvous_threads("Shenandoah Class Unloading");
175175
}
176176

177177
// Purge stale metadata and nmethods that were unlinked

0 commit comments

Comments
 (0)