-
Notifications
You must be signed in to change notification settings - Fork 97
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8323274: C2: array load may float above range check
Backport-of: 4406915ebce4266b3eb4a238382fff3c2c1d1739
- Loading branch information
1 parent
c08de56
commit a1e43d9
Showing
9 changed files
with
672 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
test/hotspot/jtreg/compiler/rangechecks/TestArrayAccessAboveRCAfterPartialPeeling.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
/* | ||
* Copyright (c) 2024, Red Hat, Inc. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @bug 8323274 | ||
* @summary partial peeling loop can cause an array load to become dependent on a test other than its range check | ||
* @run main/othervm -XX:-UseOnStackReplacement -XX:-TieredCompilation -XX:-BackgroundCompilation TestArrayAccessAboveRCAfterPartialPeeling | ||
*/ | ||
|
||
public class TestArrayAccessAboveRCAfterPartialPeeling { | ||
private static volatile int volatileField; | ||
|
||
public static void main(String[] args) { | ||
int[] array = new int[100]; | ||
for (int i = 0; i < 20_000; i++) { | ||
test(array, 2, true, 1); | ||
test(array, 2, false, 1); | ||
inlined(array, 2, 42, true, 42, 1, 1); | ||
inlined(array, 2, 42, false, 42, 1, 1); | ||
} | ||
try { | ||
test(array, 2, true, -1); | ||
} catch (ArrayIndexOutOfBoundsException arrayIndexOutOfBoundsException) { | ||
} | ||
} | ||
|
||
private static int test(int[] array, int k, boolean flag, int j) { | ||
int l; | ||
for (l = 1; l < 2; l *= 2) { | ||
|
||
} | ||
int m; | ||
for (m = 0; m < 42; m += l) { | ||
|
||
} | ||
int n; | ||
for (n = 0; n < 10; n += m/42) { | ||
|
||
} | ||
return inlined(array, k, l, flag, m, n/10, j); | ||
} | ||
|
||
private static int inlined(int[] array, int k, int l, boolean flag, int m, int n, int j) { | ||
if (array == null) { | ||
} | ||
int[] otherArray = new int[100]; | ||
int i = 0; | ||
int v = 0; | ||
if (k == m) { | ||
} | ||
|
||
if (flag) { | ||
v += array[j]; | ||
v += otherArray[i]; | ||
|
||
for (; ; ) { | ||
synchronized (new Object()) { | ||
} | ||
if (j >= 100) { | ||
break; | ||
} | ||
if (k == 42) { | ||
} | ||
v += array[j]; | ||
v += otherArray[i]; | ||
if (i >= n) { | ||
otherArray[i] = v; | ||
} | ||
v += array[j]; | ||
if (l == 2) { | ||
break; | ||
} | ||
i++; | ||
j *= 2; | ||
volatileField = 42; | ||
k = 2; | ||
l = 42; | ||
} | ||
} else { | ||
v += array[j]; | ||
v += otherArray[i]; | ||
|
||
for (; ; ) { | ||
synchronized (new Object()) { | ||
} | ||
if (j >= 100) { | ||
break; | ||
} | ||
if (k == 42) { | ||
} | ||
v += array[j]; | ||
v += otherArray[i]; | ||
if (i >= n) { | ||
otherArray[i] = v; | ||
} | ||
v += array[j]; | ||
if (l == 2) { | ||
break; | ||
} | ||
i++; | ||
j *= 2; | ||
volatileField = 42; | ||
k = 2; | ||
l = 42; | ||
} | ||
} | ||
return v; | ||
} | ||
} |
Oops, something went wrong.
a1e43d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues