Skip to content

Commit

Permalink
8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fa…
Browse files Browse the repository at this point in the history
…iled with: Invalid ECDH ServerKeyExchange signature

Reviewed-by: lucy
Backport-of: c6f0a35e9e3eeaab1e238e8712051a626b337e0b
  • Loading branch information
GoeLin committed Oct 31, 2024
1 parent c1a3c4f commit d7c85b1
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion test/jdk/sun/security/pkcs11/PKCS11Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public abstract class PKCS11Test {

// Version of the NSS artifact. This coincides with the version of
// the NSS version
private static final String NSS_BUNDLE_VERSION = "3.96";
private static final String NSS_BUNDLE_VERSION = "3.101";
private static final String NSSLIB = "jpg.tests.jdk.nsslib";

static double nss_version = -1;
Expand Down
10 changes: 7 additions & 3 deletions test/jdk/sun/security/pkcs11/Signature/TestDSAKeyLength.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -48,8 +48,12 @@ public static void main(String[] args) throws Exception {

@Override
protected boolean skipTest(Provider provider) {
if (isNSS(provider) && (getNSSVersion() == 0.0 || getNSSVersion() >= 3.14)) {
System.out.println("Skip testing NSS " + getNSSVersion());
double version = getNSSVersion();
String[] versionStrs = Double.toString(version).split("\\.");
int major = Integer.parseInt(versionStrs[0]);
int minor = Integer.parseInt(versionStrs[1]);
if (isNSS(provider) && (version == 0.0 || (major >= 3 && minor >= 14))) {
System.out.println("Skip testing NSS " + version);
return true;
}

Expand Down

3 comments on commit d7c85b1

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented on d7c85b1 Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on d7c85b1 Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-d7c85b19-master in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit d7c85b19 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 31 Oct 2024 and was reviewed by Lutz Schmidt.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-GoeLin-d7c85b19-master:backport-GoeLin-d7c85b19-master
$ git checkout backport-GoeLin-d7c85b19-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-GoeLin-d7c85b19-master

Please sign in to comment.