Skip to content

Commit e4f2357

Browse files
committed
8372348: Adjust some UL / JFR string deduplication output messages
Backport-of: 4044c37d40cec86a80b1c07a95c2e05900b34df2
1 parent 6dac907 commit e4f2357

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

src/hotspot/share/gc/shared/stringdedup/stringDedupStat.cpp

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,17 @@ void StringDedup::Stat::log_summary(const Stat* last_stat, const Stat* total_sta
101101

102102
log_info(stringdedup)(
103103
"Concurrent String Deduplication "
104-
"%zu/" STRDEDUP_BYTES_FORMAT_NS " (new), "
104+
"%zu (inspected), "
105+
"%zu/" STRDEDUP_BYTES_FORMAT_NS " (new unknown), "
105106
"%zu/" STRDEDUP_BYTES_FORMAT_NS " (deduped), "
106-
"avg " STRDEDUP_PERCENT_FORMAT_NS ", "
107+
"total avg deduped/new unknown bytes " STRDEDUP_PERCENT_FORMAT_NS ", "
108+
STRDEDUP_BYTES_FORMAT_NS " (total deduped)," STRDEDUP_BYTES_FORMAT_NS " (total new unknown), "
107109
STRDEDUP_ELAPSED_FORMAT_MS " of " STRDEDUP_ELAPSED_FORMAT_MS,
110+
last_stat->_inspected,
108111
last_stat->_new, STRDEDUP_BYTES_PARAM(last_stat->_new_bytes),
109112
last_stat->_deduped, STRDEDUP_BYTES_PARAM(last_stat->_deduped_bytes),
110113
total_deduped_bytes_percent,
114+
STRDEDUP_BYTES_PARAM(total_stat->_deduped_bytes), STRDEDUP_BYTES_PARAM(total_stat->_new_bytes),
111115
strdedup_elapsed_param_ms(last_stat->_process_elapsed),
112116
strdedup_elapsed_param_ms(last_stat->_active_elapsed));
113117
}
@@ -218,14 +222,14 @@ void StringDedup::Stat::log_statistics(bool total) const {
218222
double replaced_percent = percent_of(_replaced, _new);
219223
double deleted_percent = percent_of(_deleted, _new);
220224
log_times(total ? "Total" : "Last");
221-
log_debug(stringdedup)(" Inspected: %12zu", _inspected);
222-
log_debug(stringdedup)(" Known: %12zu(%5.1f%%)", _known, known_percent);
223-
log_debug(stringdedup)(" Shared: %12zu(%5.1f%%)", _known_shared, known_shared_percent);
224-
log_debug(stringdedup)(" New: %12zu(%5.1f%%)" STRDEDUP_BYTES_FORMAT,
225+
log_debug(stringdedup)(" Inspected: %12zu", _inspected);
226+
log_debug(stringdedup)(" Known: %12zu(%5.1f%%)", _known, known_percent);
227+
log_debug(stringdedup)(" Shared: %12zu(%5.1f%%)", _known_shared, known_shared_percent);
228+
log_debug(stringdedup)(" New unknown: %12zu(%5.1f%%)" STRDEDUP_BYTES_FORMAT,
225229
_new, new_percent, STRDEDUP_BYTES_PARAM(_new_bytes));
226-
log_debug(stringdedup)(" Replaced: %12zu(%5.1f%%)", _replaced, replaced_percent);
227-
log_debug(stringdedup)(" Deleted: %12zu(%5.1f%%)", _deleted, deleted_percent);
228-
log_debug(stringdedup)(" Deduplicated: %12zu(%5.1f%%)" STRDEDUP_BYTES_FORMAT "(%5.1f%%)",
230+
log_debug(stringdedup)(" Replaced: %12zu(%5.1f%%)", _replaced, replaced_percent);
231+
log_debug(stringdedup)(" Deleted: %12zu(%5.1f%%)", _deleted, deleted_percent);
232+
log_debug(stringdedup)(" Deduplicated: %12zu(%5.1f%%)" STRDEDUP_BYTES_FORMAT "(%5.1f%%)",
229233
_deduped, deduped_percent, STRDEDUP_BYTES_PARAM(_deduped_bytes), deduped_bytes_percent);
230234
log_debug(stringdedup)(" Skipped: %zu (dead), %zu (incomplete), %zu (shared)",
231235
_skipped_dead, _skipped_incomplete, _skipped_shared);

0 commit comments

Comments
 (0)