Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 #1012

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 26, 2024

I backport this for parity with 21.0.6-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8338924 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8335664 needs maintainer approval

Issues

  • JDK-8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 (Bug - P4 - Approved)
  • JDK-8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1012/head:pull/1012
$ git checkout pull/1012

Update a local copy of the PR:
$ git checkout pull/1012
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1012

View PR using the GUI difftool:
$ git pr show -t 1012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1012.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 26, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5
8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 0943249: 8321940: Improve CDSHeapVerifier in handling of interned strings
  • e756145: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
  • c8b8f72: 8340383: VM issues warning failure to find kernel32.dll on Windows nanoserver
  • c66748c: 8340815: Add SECURITY.md file
  • 5be5942: 6942632: Hotspot should be able to use more than 64 logical processors on Windows
  • 3b2b321: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
  • cb81169: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport caf28d4ac5711cc864a05fbdd64451d364c599ef 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 Sep 26, 2024
@openjdk
Copy link

openjdk bot commented Sep 26, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 26, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 26, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 26, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 27, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 1, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

Going to push as commit dd13bf6.
Since your change was applied there have been 8 commits pushed to the master branch:

  • aa6cdd7: 8324841: PKCS11 tests still skip execution
  • 0943249: 8321940: Improve CDSHeapVerifier in handling of interned strings
  • e756145: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
  • c8b8f72: 8340383: VM issues warning failure to find kernel32.dll on Windows nanoserver
  • c66748c: 8340815: Add SECURITY.md file
  • 5be5942: 6942632: Hotspot should be able to use more than 64 logical processors on Windows
  • 3b2b321: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
  • cb81169: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 1, 2024
@openjdk openjdk bot closed this Oct 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@GoeLin Pushed as commit dd13bf6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant