Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322772: Clean up code after JDK-8322417 #104

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Dec 29, 2023

Hi all,

This pull request contains a backport of JDK-8322772, commit 32d80e2c from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 29 Dec 2023 and was reviewed by Martin Doerr, Goetz Lindenmaier, Matthias Baesken and Vyom Tewari.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322772 needs maintainer approval

Issue

  • JDK-8322772: Clean up code after JDK-8322417 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/104/head:pull/104
$ git checkout pull/104

Update a local copy of the PR:
$ git checkout pull/104
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 104

View PR using the GUI difftool:
$ git pr show -t 104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/104.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 32d80e2caf6063b58128bd5f3dc87b276f3bd0cb 8322772: Clean up code after JDK-8322417 Dec 29, 2023
@openjdk
Copy link

openjdk bot commented Dec 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 29, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 29, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/approval request Requesting approval for a small code cleanup. Risk is zero, given that the build is green. Testing: GHA and SAP nightlies.

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@RealCLanger
8322772: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 29, 2023
@openjdk
Copy link

openjdk bot commented Dec 30, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322772: Clean up code after JDK-8322417

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 30, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 31, 2023

Going to push as commit 24b3b2b.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 98fb425: 8320206: Some intrinsics/stubs missing vzeroupper on x86_64
  • 3465179: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 31, 2023
@openjdk openjdk bot closed this Dec 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 31, 2023
@openjdk
Copy link

openjdk bot commented Dec 31, 2023

@RealCLanger Pushed as commit 24b3b2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants