-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8322772: Clean up code after JDK-8322417 #104
8322772: Clean up code after JDK-8322417 #104
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Requesting approval for a small code cleanup. Risk is zero, given that the build is green. Testing: GHA and SAP nightlies. |
@RealCLanger |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 24b3b2b.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 24b3b2b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8322772, commit 32d80e2c from the openjdk/jdk repository.
The commit being backported was authored by Christoph Langer on 29 Dec 2023 and was reviewed by Martin Doerr, Goetz Lindenmaier, Matthias Baesken and Vyom Tewari.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/104/head:pull/104
$ git checkout pull/104
Update a local copy of the PR:
$ git checkout pull/104
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/104/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 104
View PR using the GUI difftool:
$ git pr show -t 104
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/104.diff
Webrev
Link to Webrev Comment