-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337876: [IR Framework] Add support for IR tests with @Stable #1043
Conversation
/issue add JDK-8338112 |
Both backports are clean, they are in the same PR so that we keep the tests clean. /clean |
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@shipilev |
@shipilev The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean backport to me.
/approval 8337876 request Adds infrastructural support for more IR tests. Applies cleanly. New tests pass, needs JDK-8338112 as the testbug followup. Risk is low, test infrastructure change. |
Thanks! |
Thanks! /integrate |
Going to push as commit eb6a23a.
Your commit was automatically rebased without conflicts. |
Improves IR test framework in preparation for
@Stable
fixes.Additional testing:
testlibrary_tests/ir_framework/tests compiler/c2/irTests
testlibrary_tests/ir_framework/tests compiler/c2/irTests
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1043/head:pull/1043
$ git checkout pull/1043
Update a local copy of the PR:
$ git checkout pull/1043
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1043/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1043
View PR using the GUI difftool:
$ git pr show -t 1043
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1043.diff
Webrev
Link to Webrev Comment