Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337876: [IR Framework] Add support for IR tests with @Stable #1043

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 10, 2024

Improves IR test framework in preparation for @Stable fixes.

Additional testing:

  • MacOS AArch64 server fastdebug, testlibrary_tests/ir_framework/tests compiler/c2/irTests
  • MacOS AArch64 server release, testlibrary_tests/ir_framework/tests compiler/c2/irTests

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8338112 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337876 needs maintainer approval

Issues

  • JDK-8337876: [IR Framework] Add support for IR tests with @Stable (Enhancement - P4 - Approved)
  • JDK-8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1043/head:pull/1043
$ git checkout pull/1043

Update a local copy of the PR:
$ git checkout pull/1043
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1043/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1043

View PR using the GUI difftool:
$ git pr show -t 1043

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1043.diff

Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

/issue add JDK-8338112

@shipilev
Copy link
Member Author

Both backports are clean, they are in the same PR so that we keep the tests clean.

/clean

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337876: [IR Framework] Add support for IR tests with @Stable
8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build

Reviewed-by: eastigeevich, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 3efdcde: 8340590: RISC-V: C2: Small improvement to vector gather load and scatter store
  • 21fec60: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'
  • 10665ba: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
  • 6967a6b: 8313878: Exclude two compiler/rtm/locking tests on ppc64le
  • 868168c: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
  • b002ba6: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c01f53ac2dab1d4d2cd1e4d45a67f9373d4a9c7e 8337876: [IR Framework] Add support for IR tests with @Stable Oct 10, 2024
@openjdk
Copy link

openjdk bot commented Oct 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 10, 2024
@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@shipilev
Adding additional issue to issue list: 8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@shipilev The /clean pull request command is not enabled for this repository

@mlbridge
Copy link

mlbridge bot commented Oct 10, 2024

Webrevs

Copy link
Member

@eastig eastig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean backport to me.

@shipilev
Copy link
Member Author

shipilev commented Oct 10, 2024

/approval 8337876 request Adds infrastructural support for more IR tests. Applies cleanly. New tests pass, needs JDK-8338112 as the testbug followup. Risk is low, test infrastructure change.
/approval 8338112 request Test bugfix for JDK-8337876, applies cleanly. Tests pass with both fastdebug and release builds. Risk is low.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@shipilev
8337876: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@shipilev
8338112: The approval request has been created successfully.

@shipilev
Copy link
Member Author

Looks clean backport to me.

Thanks!

@openjdk openjdk bot added approval and removed approval labels Oct 10, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2024
@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

Going to push as commit eb6a23a.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 3efdcde: 8340590: RISC-V: C2: Small improvement to vector gather load and scatter store
  • 21fec60: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'
  • 10665ba: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
  • 6967a6b: 8313878: Exclude two compiler/rtm/locking tests on ppc64le
  • 868168c: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
  • b002ba6: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2024
@openjdk openjdk bot closed this Oct 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@shipilev Pushed as commit eb6a23a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-MULTI-irtests-stable branch January 8, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants