8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter

[zifeihan]

Hi, The same issue also exists in the jdk21u. I would like to backport 8341146 to jdk21u-dev. becasue jdk21u-dev not have JDK-8301997, so this backport is not clean. This is a risc-v specific change, risk is low.

Testing on SOPHON SG2042 (release)

• JCstress
• Run tier1 tests
• ~5% improvement on SPECJbb2005 score (-Xint -XX:+UseParallelGC)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8341146 needs maintainer approval

Issue

• JDK-8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter (Enhancement - P4 - Approved)

Reviewers

• Feilong Jiang (@feilongjiang - no project role)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1044/head:pull/1044
$ git checkout pull/1044

Update a local copy of the PR:
$ git checkout pull/1044
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1044

View PR using the GUI difftool:
$ git pr show -t 1044

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1044.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter

Reviewed-by: fjiang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• e5dfeb1: 8342063: [21u][aix] Backport introduced redundant line in ProblemList
• 62e0147: Merge
• dfcd8d2: 8341989: [21u] Back out JDK-8327501 and JDK-8328366
• 0083bcd: 8341674: [21u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 21.0.5
• 90517f5: 8332644: Improve graph optimizations
• 2058719: 8331446: Improve deserialization support
• 0832548: 8328726: Better Kerberos support
• be1607d: 8335713: Enhance vectorization analysis
• d953c9f: 8328544: Improve handling of vectorization
• 846b6eb: 8328286: Enhance HTTP client
• ... and 16 more: https://git.openjdk.org/jdk21u-dev/compare/978075f67da50403105726105f5aa22fecd9149c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (4d6977c9)

[feilongjiang]

Looks good, thanks!

[zifeihan]

/integrate

[openjdk]

@zifeihan
Your change (at version 4d6977c) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit f9070df.
Since your change was applied there have been 26 commits pushed to the master branch:

• e5dfeb1: 8342063: [21u][aix] Backport introduced redundant line in ProblemList
• 62e0147: Merge
• dfcd8d2: 8341989: [21u] Back out JDK-8327501 and JDK-8328366
• 0083bcd: 8341674: [21u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 21.0.5
• 90517f5: 8332644: Improve graph optimizations
• 2058719: 8331446: Improve deserialization support
• 0832548: 8328726: Better Kerberos support
• be1607d: 8335713: Enhance vectorization analysis
• d953c9f: 8328544: Improve handling of vectorization
• 846b6eb: 8328286: Enhance HTTP client
• ... and 16 more: https://git.openjdk.org/jdk21u-dev/compare/978075f67da50403105726105f5aa22fecd9149c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit f9070df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.