Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320892: AArch64: Restore FPU control state after JNI #1051

Closed
wants to merge 1 commit into from

Conversation

bulasevich
Copy link

@bulasevich bulasevich commented Oct 14, 2024

Clean backport to avoid FPU control state corruption.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320892 needs maintainer approval

Issue

  • JDK-8320892: AArch64: Restore FPU control state after JNI (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1051/head:pull/1051
$ git checkout pull/1051

Update a local copy of the PR:
$ git checkout pull/1051
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1051

View PR using the GUI difftool:
$ git pr show -t 1051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1051.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320892: AArch64: Restore FPU control state after JNI

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 50f31240555888018f0f496ab29c8a5932dce459 8320892: AArch64: Restore FPU control state after JNI Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

⚠️ @bulasevich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2024

Webrevs

@bulasevich
Copy link
Author

/approval request
Clean backport to avoid unexpected behavior caused by FPU control state corruption.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@bulasevich
8320892: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 14, 2024
@bulasevich
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@bulasevich
Your change (at version d423017) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

Going to push as commit 27d2abe.
Since your change was applied there have been 21 commits pushed to the master branch:

  • fe4b0fa: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
  • dd4e0ae: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
  • f19e69a: 8342014: RISC-V: ZStoreBarrierStubC2 clobbers rflags
  • 70eff9d: 8340109: Ubsan: ciEnv.cpp:1660:65: runtime error: member call on null pointer of type 'struct CompileTask'
  • 6ed940b: 8320682: [AArch64] C1 compilation fails with "Field too big for insn"
  • fbfe11f: 8341024: [test] build/AbsPathsInImage.java fails with OOM when using ubsan-enabled binaries
  • f766080: 8320397: RISC-V: Avoid passing t0 as temp register to MacroAssembler:: cmpxchg_obj_header/cmpxchgptr
  • 8e19c8f: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
  • f9070df: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
  • e5dfeb1: 8342063: [21u][aix] Backport introduced redundant line in ProblemList
  • ... and 11 more: https://git.openjdk.org/jdk21u-dev/compare/9e582fcbb8ab34b44ff01ac13de5cc4d6487396d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2024
@openjdk openjdk bot closed this Oct 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 17, 2024
@openjdk
Copy link

openjdk bot commented Oct 17, 2024

@phohensee @bulasevich Pushed as commit 27d2abe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants